Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <24265580.1188714438965.JavaMail.jira@brutus>
Date: Sat, 1 Sep 2007 23:27:18 -0700 (PDT)
From: "Sergey Dmitriev (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-4703) [drlvm][thread] minor
 hythread_safe_point_other improvement
In-Reply-To: <12878488.1188556230738.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HARMONY-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524322 ] 

Sergey Dmitriev commented on HARMONY-4703:
------------------------------------------

Just wanted to make you know that this patch is OK with Oracle App Server startup.

> [drlvm][thread] minor hythread_safe_point_other improvement
> -----------------------------------------------------------
>
>                 Key: HARMONY-4703
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4703
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Aleksey Shipilev
>            Priority: Minor
>         Attachments: HARMONY-4703.patch
>
>
> Current implementation of hythread_safe_point_other which is called from hythread_suspend_disable looks like this:
> void VMCALL hythread_safe_point_other(hythread_t thread)
> {
>     thread_safe_point_impl(tm_self_tls);
> }
> So, we are receiving hythread itself as the argument, then we throw it away and ask again for hythread_self via tm_self_tls alias.
> We might throw away one TLS get then by simply passing thread downstream:
> void VMCALL hythread_safe_point_other(hythread_t thread)
> {
>     thread_safe_point_impl(thread);
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.