harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oliver Deakin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-4523) [classlib][swing]BasicSliderUI.ActionScroller should be marked with notImplementedException
Date Tue, 04 Sep 2007 13:14:44 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524716
] 

Oliver Deakin commented on HARMONY-4523:
----------------------------------------

Ah sorry Dmitry, I think you misunderstood 2, I should have been more clear. I didn't mean
that the full implementation was "return true;". I meant the implementation is "return enabled;"
where enabled is the name of the variable inherited from the AbstractAction class (the superclass
of BasicSliderUI.ActionScroller) and indicates if the action is enabled or not. So the method
implementation would look like:

public boolean isEnabled() {
    return enabled;
}

Thanks Dmitry - I have applied these changes at repo revision r572661. Please verify that
they have been applied correctly.

> [classlib][swing]BasicSliderUI.ActionScroller should be marked with notImplementedException
> -------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4523
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4523
>             Project: Harmony
>          Issue Type: Task
>          Components: Classlib
>            Reporter: Dmitry Irlyanov
>            Assignee: Oliver Deakin
>            Priority: Trivial
>         Attachments: H4523-BasicSliderUI-way1.patch, H4523-BasicSliderUI-way2.patch,
H4523-BasicSliderUI.patch
>
>
> BasicSliderUI.ActionScroller class is obsolete since 1.3 (it's indicated in javadoc 1.5)
 and unimplemented, but the methods aren't marked with NotImplementedExeption

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message