harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From smish...@apache.org
Subject svn commit: r576261 - /harmony/enhanced/buildtest/branches/2.0/tests/functional/src/test/share/org/apache/harmony/test/share/dt/RemoteSystem.java
Date Mon, 17 Sep 2007 05:22:45 GMT
Author: smishura
Date: Sun Sep 16 22:22:44 2007
New Revision: 576261

URL: http://svn.apache.org/viewvc?rev=576261&view=rev
Log:
Set 15min as default timeout for RemoteSystem
Intinite timeout may hang the suite (I periodically observe RemoteSystem processes left by
the suite run)

Modified:
    harmony/enhanced/buildtest/branches/2.0/tests/functional/src/test/share/org/apache/harmony/test/share/dt/RemoteSystem.java

Modified: harmony/enhanced/buildtest/branches/2.0/tests/functional/src/test/share/org/apache/harmony/test/share/dt/RemoteSystem.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/buildtest/branches/2.0/tests/functional/src/test/share/org/apache/harmony/test/share/dt/RemoteSystem.java?rev=576261&r1=576260&r2=576261&view=diff
==============================================================================
--- harmony/enhanced/buildtest/branches/2.0/tests/functional/src/test/share/org/apache/harmony/test/share/dt/RemoteSystem.java
(original)
+++ harmony/enhanced/buildtest/branches/2.0/tests/functional/src/test/share/org/apache/harmony/test/share/dt/RemoteSystem.java
Sun Sep 16 22:22:44 2007
@@ -87,7 +87,15 @@
      */
     public RemoteSystem(final int port, final int soTimeout) throws IOException {
         serverSocket = new ServerSocket(port);
-        serverSocket.setSoTimeout(soTimeout);
+        if ( soTimeout==0 ) {
+            // FIXME: timeout should be passed by framework as parameter
+            // 
+            // Don't set intinite timeout - set 15min as default timeout
+            // Otherwise in case of tests failure the suite run may hang
+            serverSocket.setSoTimeout(900000);
+        } else {
+            serverSocket.setSoTimeout(soTimeout);
+        }
         serverSocket.setReuseAddress(true);
         system = this;
         instances = new Hashtable();



Mime
View raw message