harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hinde...@apache.org
Subject svn commit: r575049 - /harmony/enhanced/classlib/trunk/modules/luni/src/main/java/org/apache/harmony/luni/platform/OSFileSystem.java
Date Wed, 12 Sep 2007 19:24:36 GMT
Author: hindessm
Date: Wed Sep 12 12:24:35 2007
New Revision: 575049

URL: http://svn.apache.org/viewvc?rev=575049&view=rev
Log:
Added comment about a bug.

Modified:
    harmony/enhanced/classlib/trunk/modules/luni/src/main/java/org/apache/harmony/luni/platform/OSFileSystem.java

Modified: harmony/enhanced/classlib/trunk/modules/luni/src/main/java/org/apache/harmony/luni/platform/OSFileSystem.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/org/apache/harmony/luni/platform/OSFileSystem.java?rev=575049&r1=575048&r2=575049&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/luni/src/main/java/org/apache/harmony/luni/platform/OSFileSystem.java
(original)
+++ harmony/enhanced/classlib/trunk/modules/luni/src/main/java/org/apache/harmony/luni/platform/OSFileSystem.java
Wed Sep 12 12:24:35 2007
@@ -149,6 +149,14 @@
 		}
 		long bytesRead = readImpl(fileDescriptor, bytes, offset, length);
 		if (bytesRead < -1) {
+                        /*
+                         * TODO: bytesRead is never less than -1 so this code
+                         * does nothing?
+                         * The native code throws an exception in only one case
+                         * so perhaps this should be 'bytesRead < 0' to handle
+                         * any other cases.  But the other cases have been
+                         * ignored until now so fixing this could break things
+                         */
 			throw new IOException();
 		}
 		return bytesRead;



Mime
View raw message