harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Shipilev (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HARMONY-4815) [classlib][nio] Charset encoding/decoding is ineffective
Date Wed, 19 Sep 2007 08:59:43 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Aleksey Shipilev updated HARMONY-4815:

    Attachment: HARMONY-4815-tests.patch

This patch causes two tests to fail:
CharsetTest.test_DecodeLjava_nio_ByteBuffer "should use the same instance"
CharsetTest.test_EncodeLjava_nio_CharBuffer "should use the same instance"

These tests checks for cached encoder/decoder, but spec does not require encoders/decoders
to be cached: http://java.sun.com/j2se/1.5.0/docs/api/java/nio/charset/Charset.html#decode(java.nio.CharBuffer)

So, I propose to disable these tests: see HARMONY-4815-tests.patch

> [classlib][nio] Charset encoding/decoding is ineffective
> --------------------------------------------------------
>                 Key: HARMONY-4815
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4815
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Aleksey Shipilev
>            Assignee: Alexey Petrenko
>         Attachments: CharsetTest.java, HARMONY-4815-tests.patch, HARMONY-4815.patch
> Excess synchronizations and caching of encoder/decoder causes stalls if many thread doing
encoding/decoding simultaneously. As far as one single instance of Encoder/Decoder is not
thread-safe, we could create the separate encoder/decoder each time it is demanded. The overhead
will be caused for excess object allocations, but boost from eliminating serial code is much

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message