Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 97244 invoked from network); 13 Aug 2007 06:34:06 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 13 Aug 2007 06:34:06 -0000 Received: (qmail 93143 invoked by uid 500); 13 Aug 2007 06:34:04 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 93124 invoked by uid 500); 13 Aug 2007 06:34:04 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 93112 invoked by uid 99); 13 Aug 2007 06:34:04 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Aug 2007 23:34:04 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Aug 2007 06:34:14 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 42C9971418F for ; Sun, 12 Aug 2007 23:33:43 -0700 (PDT) Message-ID: <9258590.1186986823257.JavaMail.jira@brutus> Date: Sun, 12 Aug 2007 23:33:43 -0700 (PDT) From: "Evgueni Brevnov (JIRA)" To: commits@harmony.apache.org Subject: [jira] Commented: (HARMONY-4599) [drlvm][jit][opt]Jitrino dublicates segment override prefix in TLS helper for Win/x86 In-Reply-To: <11990174.1186144793137.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HARMONY-4599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519378 ] Evgueni Brevnov commented on HARMONY-4599: ------------------------------------------ I agree style fixes would better be separated. In this particular case I don't think one line style fix complicates patch review a lot. Thank you. Evgueni > [drlvm][jit][opt]Jitrino dublicates segment override prefix in TLS helper for Win/x86 > -------------------------------------------------------------------------------------- > > Key: HARMONY-4599 > URL: https://issues.apache.org/jira/browse/HARMONY-4599 > Project: Harmony > Issue Type: Bug > Components: DRLVM > Environment: x86/Windows Server 2003 > Harmony VM:r559723 > Reporter: vasily.v.levchenko@gmail.com > Assignee: Mikhail Fursov > Priority: Trivial > Attachments: double_tls_access.patch > > > Hi folks, > I've noticed that Jitrino duplicate the segment override prefix in TLS related templates: > 0x00000000237f0f7d 81ea02000000 sub edx,2 > 0x00000000237f0f83 89542458 mov dword ptr [esp+58h],edx > 0x00000000237f0f87 64 ??? > 0x00000000237f0f88 648b1514000000 mov edx,dword ptr fs:[14h] > 0x00000000237f0f8f 81c204000000 add edx,4 > Harmony build: r559723 > Should be: > 81ea02000000 sub edx,2 > 89542458 mov dword ptr [esp+58h],edx > 648b1514000000 mov edx,dword ptr fs:[14h] > 81c204000000 add edx,4 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.