Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <6104.1188490590600.JavaMail.jira@brutus>
Date: Thu, 30 Aug 2007 09:16:30 -0700 (PDT)
From: "Oliver Deakin (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-4523)
 [classlib][swing]BasicSliderUI.ActionScroller should be marked with
 notImplementedException
In-Reply-To: <3642585.1185268411355.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HARMONY-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523875 ] 

Oliver Deakin commented on HARMONY-4523:
----------------------------------------

Yes, that patch is closer to what I was thinking of. Just a couple of small things:
1) Should we put a "throw new NotImplementedException();" into the actionPerformed() method so that anyone calling it is told immediately that it will not behave as expected without inspecting the code?
2) It seems that the implementation of isEnabled() is simply "return enabled". In this case, we could implement this immediately and remove the "throws NotImplementedException" from the method signature. What do you think?

> [classlib][swing]BasicSliderUI.ActionScroller should be marked with notImplementedException
> -------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4523
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4523
>             Project: Harmony
>          Issue Type: Task
>          Components: Classlib
>            Reporter: Dmitry Irlyanov
>            Assignee: Oliver Deakin
>            Priority: Trivial
>         Attachments: H4523-BasicSliderUI.patch
>
>
> BasicSliderUI.ActionScroller class is obsolete since 1.3 (it's indicated in javadoc 1.5)  and unimplemented, but the methods aren't marked with NotImplementedExeption

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.