Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <27991654.1187576490637.JavaMail.jira@brutus>
Date: Sun, 19 Aug 2007 19:21:30 -0700 (PDT)
From: "Andrew Zhang (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-4649) [p-unit] memory utils, fixes
In-Reply-To: <18633699.1187443833378.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HARMONY-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521000 ] 

Andrew Zhang commented on HARMONY-4649:
---------------------------------------

Hi Alexei, 

Excellent! Thanks for the improvement.  I only have one question about the commit:

  * Fixed testInstance allocation: allocate it once for class (as it is done in ng-unit). 

Where's the exact code? Does it mean that the test methods will affect each other?

Best regards,
Andrew


> [p-unit] memory utils, fixes
> ----------------------------
>
>                 Key: HARMONY-4649
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4649
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Misc
>            Reporter: Alexei Fedotov
>
> Andrew, sorry for delay. Here go some improvements.
>    * Added junit-style shouldStop() method to detect timeout expiration from inside the test
>    * Allocate thread objects once for all test iterations.
>    * Replaced logger.* and assert.* domains with sensible ones.
>    * Slightly corrected messages in float and double asserts.
>    * Fixed testInstance allocation: allocate it once for class (as it is done in ng-unit).
>    * Improved memory deallocation algorithm in MemoryUtil.clear() to free objects with finalizers on RI, added wilderness utilities and maximum total memory calculation. Restored org.punit.exception.OutOfMemoryException. Added related test.
>    * Fixed Maximum/Minimum watcher value accumulation in case when _scale changes.
>    * Fixed formatting and tabs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.