Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <18952099.1185969113057.JavaMail.jira@brutus>
Date: Wed, 1 Aug 2007 04:51:53 -0700 (PDT)
From: "Tim Ellison (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Resolved: (HARMONY-4578) [classlib][beans]
 o.a.h.b.editors.ColorEditor & FontEditor do not have correct behaviors
In-Reply-To: <14239138.1185868553033.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HARMONY-4578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ellison resolved HARMONY-4578.
----------------------------------

    Resolution: Fixed

Thanks Spark.

Patch applied to BEANS module at repo revision r561769.

Please check it was applied as you expected.


> [classlib][beans] o.a.h.b.editors.ColorEditor & FontEditor do not have correct behaviors
> ----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4578
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4578
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: spark shen
>            Assignee: Tim Ellison
>         Attachments: HY-4578.patch
>
>
> The behavior of o.a.h.b.editors.ColorEditor was not correctly implemented. Neither does FontEditor.
> The following test case will give a hint.
> public void testFontEditor() throws Exception{
>         PropertyEditor e2 = PropertyEditorManager.findEditor(Font.class);
>         Font font = new Font("Helvetica", Font.PLAIN, 12);
>         e2.setValue(font);
>         assertNull(e2.getAsText());
>         assertNull(e2.getTags());
>         assertSame(font, e2.getValue());
>         assertTrue(e2.isPaintable());
>         Component c = e2.getCustomEditor();
>         assertSame(c, e2);
>         e2.addPropertyChangeListener(new ExceptionPropertyChangeListener());
>         try {
>             e2.setValue(null);
>             fail("Should throw an error");
>         } catch (MockError e) {
>             // expected
>             assertNull(e2.getValue());
>         }
>         
>         try {
>             e2.setValue(new Font("Arial", Font.BOLD, 10));
>             fail("Should throw an error");
>         } catch (MockError e) {
>             // expected
>         }
>     }
> I will give a patch to amend the behavior of the 2 editors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.