harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oliver Deakin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-4523) [classlib][swing]BasicSliderUI.ActionScroller should be marked with notImplementedException
Date Wed, 29 Aug 2007 16:26:30 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523623

Oliver Deakin commented on HARMONY-4523:

Hi Dmitry,

A couple of comments on the patch:
 - I think the methods should contain a "throw new NotImplementedException();" so that anyone
who calls these methods knows that they are not giving the expected results for a reason.
These can be seen in other classes with unimplemented methods (for example, javax.swing.JLabel.AccessibleJLabel).
Do you agree?

 - After the above change, I see a test failure in javax.swing.plaf.basic.BasicSliderUITest.testActionScrollerEnabled().
This test was added as part of HARMONY-2591 which was concerned with BasicSliderUI.ActionScroller
compatibility with the RI. Although this class is described as being "no longer used" in the
documentation, perhaps for backward compatility (and RI compatibility) we should keep the
isEnabled() method implemented as "return true" and just mark the constructor and actionPerformed
methods as not implemented pending future implementation?

> [classlib][swing]BasicSliderUI.ActionScroller should be marked with notImplementedException
> -------------------------------------------------------------------------------------------
>                 Key: HARMONY-4523
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4523
>             Project: Harmony
>          Issue Type: Task
>          Components: Classlib
>            Reporter: Dmitry Irlyanov
>            Assignee: Oliver Deakin
>            Priority: Trivial
>         Attachments: H4523-BasicSliderUI.patch
> BasicSliderUI.ActionScroller class is obsolete since 1.3 (it's indicated in javadoc 1.5)
 and unimplemented, but the methods aren't marked with NotImplementedExeption

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message