harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Zhang (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-4502) [p-unit] parametrizing tests via properties
Date Fri, 20 Jul 2007 00:16:06 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-4502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514055

Andrew Zhang commented on HARMONY-4502:

Hi Alexei,

Excellent! The patch looks very good to me. Would you please commit the patch? Thanks a lot!

Best regards,

> [p-unit] parametrizing tests via properties
> -------------------------------------------
>                 Key: HARMONY-4502
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4502
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Misc
>            Reporter: Alexei Fedotov
>         Attachments: property_parametrized.patch
> Andrew,
> Please review the patch. Here goes change list:
>  * Added a new EventListener which sets public test fields on start up. Added listener
package and a test for a new functionality.
>  * Renamed Parameterizable -> Parameterized. The latter one has fewer letters and
my spellchecker doesn't underline it with red.
>  * Renamed setup -> setUp to be consistent with JUnit.
>  * Enhanced before/after class events to take a test instance instead a class, fixed
TODO comment to supply an exception to an after class listener.
>  * Fixed a number of misspells and added few lines of javadoc.
>  * Removed TypeUtil class, moved the checks to the Convention interface. Added org.punit.convention.AbstractConvention
minimizing code duplication.
>  * Removed toAbort() timeout from the Loop interface.
> Please don't hesitate to let me know if you disagree with changes (renaming issues in
particular) - this won't take too much to rollback them.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message