harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "spark shen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-4527) Signature mismatches in beans code
Date Wed, 25 Jul 2007 03:24:34 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-4527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515144
] 

spark shen commented on HARMONY-4527:
-------------------------------------

Sorry, I did not catch you here. I looked into java5 spec, the methods you mentioned all have
public modifier. And it can be proved by running the following test case on RI5.

import java.beans.PropertyEditor;
import java.lang.reflect.Method;
import java.lang.reflect.Modifier;

public class Test {
    @SuppressWarnings("nls")
    public static void main(String[] args) {
        try {
            Method method = PropertyEditor.class.getMethod("getCustomEditor",
                    (Class<?>[]) null);
            System.out.println(method.getModifiers() + " = "
                    + Modifier.ABSTRACT + "(Modifier.ABSTRACT) + "
                    + Modifier.PUBLIC + "(Modifier.PUBLIC)");
        } catch (Exception e) {
            e.printStackTrace();
        }
    }
}


> Signature mismatches in beans code
> ----------------------------------
>
>                 Key: HARMONY-4527
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4527
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: Winx86 build r558789
>            Reporter: Andrew Cornwall
>            Priority: Minor
>
> PropertyEditor and PropertyEditorSupport have methods whose signature does not match
the Sun implementation.
> They are:
> abstract public interface java.beans.PropertyEditor
>  - public java.awt.Component getCustomEditor() - should be package private, not public
>  - public void paintValue(java.awt.Graphics, java.awt.Rectangle) - should be package
private, not public
> public class java.beans.PropertyEditorSupport implements java.beans.PropertyEditor
> - public PropertyEditorSupport() - should be protected, not public
> - public PropertyEditorSupport(java.lang.Object) - should be protected, not public

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message