Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <686219.1182231146205.JavaMail.jira@brutus>
Date: Mon, 18 Jun 2007 22:32:26 -0700 (PDT)
From: "Robert Hu (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-4203) [classlib][luni][java6] New
 feature of java.util.PriorityQueue for java6
In-Reply-To: <24133977.1182149186289.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HARMONY-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506049 ] 

Robert Hu commented on HARMONY-4203:
------------------------------------

Tim. I think at least half of this patch is Java 6 specific.
#1 (change of "remove" method) is a different behavior in Java 6, you can also apply this patch into Java 5 trunk and you can see the updated PriorityQueueTest can passes on RI 6 but fails on RI 5. So, it is Java 6 specific.
#2 may be also a feature of Java 5. But according to the spec, there's no doc of methods "contains(Object object),toArray(),toArray(T[] array)" of PriorityQueue in Java 5. In Java 5, these 3 methods are maked as "Methods inherited from sub class XXX". We can see that they're "pulled down" to the class PriorityQueue in Java 6.

So, I think we have two choices now, one is to apply this patch only into Java 6 branch, the other is to split it into 2 patches, one for Java 5 including the 3 inherited methods and one for Java 6 including only the update of "remove" mehtod and related test cases.

Tim, any idea? Thanks a lot!

> [classlib][luni][java6] New feature of java.util.PriorityQueue for java6
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-4203
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4203
>             Project: Harmony
>          Issue Type: New Feature
>          Components: Classlib
>            Reporter: Robert Hu
>            Assignee: Tim Ellison
>         Attachments: HARMONY-4203.diff
>
>
> I've added the new feature of java.util.PriorityQueue for java6:
> 1. the behavior of remove method is changed, and some relative test cases is added
> 2. some methods in "java.util.AbstractCollection" of java5 are moved into java.util.PriorityQueue (push down) of java6, also with some relative test cases:
>           public boolean contains(Object object)
>           public Object[] toArray()
>           public <T> T[] toArray(T[] array)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.