Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 86271 invoked from network); 9 Jun 2007 14:09:47 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 9 Jun 2007 14:09:47 -0000 Received: (qmail 23063 invoked by uid 500); 9 Jun 2007 14:09:50 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 23042 invoked by uid 500); 9 Jun 2007 14:09:50 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 22985 invoked by uid 99); 9 Jun 2007 14:09:50 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Jun 2007 07:09:50 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Jun 2007 07:09:46 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 2F9267141F8 for ; Sat, 9 Jun 2007 07:09:26 -0700 (PDT) Message-ID: <25888377.1181398166192.JavaMail.jira@brutus> Date: Sat, 9 Jun 2007 07:09:26 -0700 (PDT) From: "Vladimir Beliaev (JIRA)" To: commits@harmony.apache.org Subject: [jira] Updated: (HARMONY-2052) [drlvm][kernel] Improve/re-implement a parser of generic signatures MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HARMONY-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Beliaev updated HARMONY-2052: -------------------------------------- Attachment: HARMONY-2052-1.diff Alexey, new version of this HARMONY-2052-1.diff does not produce warnings... Thanks for the catching this. > [drlvm][kernel] Improve/re-implement a parser of generic signatures > ------------------------------------------------------------------- > > Key: HARMONY-2052 > URL: https://issues.apache.org/jira/browse/HARMONY-2052 > Project: Harmony > Issue Type: Task > Components: Classlib, DRLVM > Reporter: Alexey Varlamov > Assignee: Paulex Yang > Priority: Minor > Attachments: antlr-2.7.5.jar, HARMONY-2052-1.diff, HARMONY-2052-1.diff, HARMONY-2052-1.diff > > > Improve/re-implement a parser of generic signatures in DRLVM kernel classes [1], and move this functionality to classlib (luni ?), so other VMs could reuse it for 1.5 support. The current impl is somewhat messy and half-baked, one need to invent more shaped and modular API to the parser. One more possible issue is parser's dependency on antlr, which may be considered overkill for this duty. I think antlr has its pros, like more illustrative code with clear correlation to formal grammar [2]; unfortunately this is not the case with the impl in question. OTOH minimizing number of dependencies for VM is always good. > [1] working_vm\vm\vmcore\src\kernel_classes\javasrc\org\apache\harmony\lang\reflect\** > [2] http://java.sun.com/docs/books/vmspec/2nd-edition/ClassFileFormat-Java5.pdf Para 4.4.4 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.