Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 78559 invoked from network); 7 Jun 2007 15:22:51 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 7 Jun 2007 15:22:51 -0000 Received: (qmail 47486 invoked by uid 500); 7 Jun 2007 15:22:51 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 47471 invoked by uid 500); 7 Jun 2007 15:22:51 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 47446 invoked by uid 99); 7 Jun 2007 15:22:51 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jun 2007 08:22:51 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jun 2007 08:22:46 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 5258D7141DC for ; Thu, 7 Jun 2007 08:22:26 -0700 (PDT) Message-ID: <1120477.1181229746334.JavaMail.jira@brutus> Date: Thu, 7 Jun 2007 08:22:26 -0700 (PDT) From: "Tim Ellison (JIRA)" To: commits@harmony.apache.org Subject: [jira] Resolved: (HARMONY-4051) [classlib][luni] Performance improvement of java.util.BitSet In-Reply-To: <1810123.1181100866111.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HARMONY-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Ellison resolved HARMONY-4051. ---------------------------------- Resolution: Fixed Thanks Robert. I applied a modified version of your code to the LUNI module at repo revision r545213. Beside cosmetic/style changes, I also reduce the visibility of #getActualArrayLength and #pop methods to private since they cannot be part of the public API. Please check that the commit resolves this issue for you. > [classlib][luni] Performance improvement of java.util.BitSet > ------------------------------------------------------------ > > Key: HARMONY-4051 > URL: https://issues.apache.org/jira/browse/HARMONY-4051 > Project: Harmony > Issue Type: Improvement > Components: Classlib > Reporter: Robert Hu > Assignee: Tim Ellison > Attachments: BitSetTest.golden.ser, HARMONY-4051.diff, patch.sh > > > The performance of java.util.BitSet can be improved. > After some modification, the performance is improved: > By running unit test of BitSet for 2000 times, the time can be reduced from 40.671s to 39.813s. > At the same time, this improvement also fix a problem of serialization. > Some test cases were also added, to ensure the correctness of improvement. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.