harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oliver Deakin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-4138) [classlib][luni] Remove unnecessary protected constructor for ServerSocket
Date Wed, 13 Jun 2007 09:19:29 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504173
] 

Oliver Deakin commented on HARMONY-4138:
----------------------------------------

Hi Kelvin - when I apply this patch and try to rebuild I get a compilation failure:

    [javac] 1. ERROR in C:\harmony\svn-checkouts\classlib-clean\modules\nio\src\main\java\org\apache\harmony\nio\internal\ServerSocketChannelImpl.java
    [javac]  (at line 223)
    [javac]     super(impl);
    [javac]     ^^^^^^^^^^^
    [javac] The constructor ServerSocket(SocketImpl) is undefined
    [javac] ----------
    [javac] 1 problem (1 error)

It appears that ServerSocketChannelImpl is using this constructor, so I don't think this is
a valid bug. Do you agree?

> [classlib][luni] Remove unnecessary protected constructor for ServerSocket
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-4138
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4138
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: Linux and Windows
>            Reporter: Kelvin Ye
>         Attachments: harmony-4138.diff
>
>
> The following protected constructor for ServerSocket is never used. 
>     protected ServerSocket(SocketImpl impl) {
>         this.impl = impl;
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message