harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Ellison (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-4051) [classlib][luni] Performance improvement of java.util.BitSet
Date Wed, 06 Jun 2007 12:06:29 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501916
] 

Tim Ellison commented on HARMONY-4051:
--------------------------------------

Robert,

I see a number of failures in REGEX after applying these changes.

One example:
java.lang.ArrayIndexOutOfBoundsException: Array index out of range: -1 at java.util.BitSet.andNot(BitSet.java:680)
at java.util.regex.CharClass.intersection(CharClass.java:395) at java.util.regex.Pattern.processRangeExpression(Pattern.java:145)
at java.util.regex.Pattern.processRange(Pattern.java:12) at java.util.regex.Pattern.processTerminal(Pattern.java:835)
at java.util.regex.Pattern.processSubExpression(Pattern.java:591) at java.util.regex.Pattern.processExpression(Pattern.java:378)
at java.util.regex.Pattern.compileImpl(Pattern.java:283) at java.util.regex.Pattern.compile(Pattern.java:264)
at java.util.regex.Pattern.compile(Pattern.java:1264) at java.util.regex.Pattern.matches(Pattern.java:1286)
at org.apache.harmony.tests.java.util.regex.MatcherTest.testUnicodeCategory(MatcherTest.java:570)

> [classlib][luni] Performance improvement of java.util.BitSet
> ------------------------------------------------------------
>
>                 Key: HARMONY-4051
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4051
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Robert Hu
>            Assignee: Tim Ellison
>         Attachments: BitSetTest.golden.ser, HARMONY-4051.diff, patch.sh
>
>
> The performance of java.util.BitSet can be improved.
> After some modification, the performance is improved:
> By running unit test of BitSet for 2000 times,  the time can be reduced from 40.671s
to 39.813s.
> At the same time, this improvement also fix a problem of serialization.
> Some test cases were also added, to ensure the correctness of improvement.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message