Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 16231 invoked from network); 22 May 2007 10:09:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 22 May 2007 10:09:37 -0000 Received: (qmail 32428 invoked by uid 500); 22 May 2007 10:09:43 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 32407 invoked by uid 500); 22 May 2007 10:09:42 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 32398 invoked by uid 99); 22 May 2007 10:09:42 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 May 2007 03:09:42 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 May 2007 03:09:36 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 7A65F71404A for ; Tue, 22 May 2007 03:09:16 -0700 (PDT) Message-ID: <31485507.1179828556498.JavaMail.jira@brutus> Date: Tue, 22 May 2007 03:09:16 -0700 (PDT) From: "Mark Hindess (JIRA)" To: commits@harmony.apache.org Subject: [jira] Commented: (HARMONY-3915) [classlib][nio] java.nio.channels.Selector.select(long timeout) throws SocketException on SIGUSR2 In-Reply-To: <4083007.1179588736423.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HARMONY-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497797 ] Mark Hindess commented on HARMONY-3915: --------------------------------------- Oops. I got up too early this morning ... I meant to write: assertEquals("elapsed time", SELECT_TIMEOUT, (time2 - time1), (SELECT_TIMEOUT * 0.05)); // 5% accuracy > [classlib][nio] java.nio.channels.Selector.select(long timeout) throws SocketException on SIGUSR2 > ------------------------------------------------------------------------------------------------- > > Key: HARMONY-3915 > URL: https://issues.apache.org/jira/browse/HARMONY-3915 > Project: Harmony > Issue Type: Bug > Components: Classlib > Environment: linux > Reporter: Sergey Dmitriev > Assigned To: Mark Hindess > Attachments: 3915.patch, 3915_test.patch > > > After fixing JIRA#3888 suddenly SelectorTest.test_wakeup() started to > fail. So fixed 3888 has discovered another issue with selector. > As it turned out java.nio.channels.Selector.select([long timeout]) > wakes up and throws SocketException when some thread dies. Actually it > is all connected with the underlying linux function > int select(int n, fd_set *readfds, fd_set *writefds, > fd_set *exceptfds, struct timeval *timeout) > and SIGUSR2 which is used in DRLVM threading subsystem (any other > threading event which sends SIGUSR2 can cause the problem with > select()). > AFAIK some time ago we had the same problem with SIGUSR2 and this > issue has been easily resolved with SA_RESTART. Unfortunately in case > of select() it is not applicable since SA_RESTART functionality in > select() is "implementation-dependent". Quote: > int select(int nfds, fd_set *readfds, fd_set *writefds, > fd_set *errorfds, struct timeval *timeout); > ... > ERRORS > Under the following conditions, select() fails and sets > errno to: > ... > [EINTR] > The select() function was interrupted before any of the > selected events occurred and before the timeout > interval expired. If SA_RESTART has been set for the > interrupting signal, it is implementation-dependent > whether select() restarts or returns with [EINTR]. > > http://www.opengroup.org/onlinepubs/007908799/xsh/select.html > As it turned out "SUSE LINUX Enterprise Server 9" on my box does not > support SA_RESTART functionality. So I handled it with cycle. And > therefore some timeout mathematics comes into play here as well. > So I believe the code-fix and test-fix for this JIRA and code-fix for > JIRA #3888 should be committed together since all this stuff intertwined. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.