Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 81339 invoked from network); 21 May 2007 20:36:39 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 21 May 2007 20:36:39 -0000 Received: (qmail 9454 invoked by uid 500); 21 May 2007 20:36:44 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 9438 invoked by uid 500); 21 May 2007 20:36:44 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 9429 invoked by uid 99); 21 May 2007 20:36:44 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 May 2007 13:36:44 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 May 2007 13:36:37 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id BC384714043 for ; Mon, 21 May 2007 13:36:16 -0700 (PDT) Message-ID: <28331477.1179779776768.JavaMail.jira@brutus> Date: Mon, 21 May 2007 13:36:16 -0700 (PDT) From: "Alexei Zakharov (JIRA)" To: commits@harmony.apache.org Subject: [jira] Commented: (HARMONY-3360) [classlib][EUT] 5 tests fail in org.eclipse.ui.workbench.texteditor.tests suit In-Reply-To: <4315078.1173693909695.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HARMONY-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497573 ] Alexei Zakharov commented on HARMONY-3360: ------------------------------------------ Hi Nellya. Thanks for the your patch and your efforts. But I think applying the patch in its present form is not a very good idea. As far as I understand internal sets of predefined symbols are affected by this patch. However, IMHO '!', '#' and other symbols don't look like space characters, do they? And it seems that applying this patch results in incorrect handling of \s class. I.e. the following test (written by me) starts to fail: import java.util.regex.*; public class TestSpace { public static void main(String argv[]) { String str = "!\"#%&'(),-./"; Pattern p = Pattern.compile("\\s"); Matcher m = p.matcher(str); boolean found = false; while (m.find()) { System.out.println("Matching subsequence: " + m.group()); found = true; } System.out.println(found ? "FAIL" : "PASS"); } } I've added this test to MatcherTest. Could we fix the original issue in some other way? > [classlib][EUT] 5 tests fail in org.eclipse.ui.workbench.texteditor.tests suit > ------------------------------------------------------------------------------ > > Key: HARMONY-3360 > URL: https://issues.apache.org/jira/browse/HARMONY-3360 > Project: Harmony > Issue Type: Bug > Components: Classlib > Reporter: Aleksey Ignatenko > Assigned To: Alexei Zakharov > Attachments: H-3360-test.patch, H-3360-updated.patch, H-3360-updated.patch, H-3360.patch > > > 5 tests fail in org.eclipse.ui.workbench.texteditor.tests suit of EUT. > 1. testSearchBackwards1 > expected:<1> but was:<2> > junit.framework.AssertionFailedError: expected:<1> but was:<2> > at org.eclipse.ui.workbench.texteditor.tests.HippieCompletionTest.testSearchBackwards1(HippieCompletionTest.java:140) > at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java) > at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:326) > at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:203) > at org.eclipse.test.UITestApplication$3.run(UITestApplication.java:188) > at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) > at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:121) > at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java) > at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2971) > at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1912) > at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1875) > at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:417) > at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java) > at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:96) > at org.eclipse.test.UITestApplication.runApplication(UITestApplication.java:130) > at org.eclipse.test.UITestApplication.run(UITestApplication.java:55) > at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:77) > at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:92) > at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:66) > at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:396) > at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176) > at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java) > at org.eclipse.core.launcher.Main.invokeFramework(Main.java:336) > at org.eclipse.core.launcher.Main.basicRun(Main.java:278) > at org.eclipse.core.launcher.Main.run(Main.java:975) > at org.eclipse.core.launcher.Main.main(Main.java:952) > at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java) > at org.apache.harmony.vm.JarRunner.main(JarRunner.java:80) > 2. testSearchBackwards2 > expected:<8> but was:<7> > junit.framework.AssertionFailedError: expected:<8> but was:<7> > at org.eclipse.ui.workbench.texteditor.tests.HippieCompletionTest.testSearchBackwards2(HippieCompletionTest.java:169) > at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java) > at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:326) > at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:203) > at org.eclipse.test.UITestApplication$3.run(UITestApplication.java:188) > at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) > at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:121) > at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java) > at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2971) > at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1912) > at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1875) > at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:417) > at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java) > at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:96) > at org.eclipse.test.UITestApplication.runApplication(UITestApplication.java:130) > at org.eclipse.test.UITestApplication.run(UITestApplication.java:55) > at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:77) > at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:92) > at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:66) > at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:396) > at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176) > at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java) > at org.eclipse.core.launcher.Main.invokeFramework(Main.java:336) > at org.eclipse.core.launcher.Main.basicRun(Main.java:278) > at org.eclipse.core.launcher.Main.run(Main.java:975) > at org.eclipse.core.launcher.Main.main(Main.java:952) > at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java) > at org.apache.harmony.vm.JarRunner.main(JarRunner.java:80) > 3. testSearch > Number of completions does not match expected:<15> but was:<9> > junit.framework.AssertionFailedError: Number of completions does not match expected:<15> but was:<9> > at org.eclipse.ui.workbench.texteditor.tests.HippieCompletionTest.testSearch(HippieCompletionTest.java:203) > at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java) > at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:326) > at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:203) > at org.eclipse.test.UITestApplication$3.run(UITestApplication.java:188) > at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) > at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:121) > at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java) > at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2971) > at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1912) > at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1875) > at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:417) > at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java) > at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:96) > at org.eclipse.test.UITestApplication.runApplication(UITestApplication.java:130) > at org.eclipse.test.UITestApplication.run(UITestApplication.java:55) > at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:77) > at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:92) > at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:66) > at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:396) > at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176) > at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java) > at org.eclipse.core.launcher.Main.invokeFramework(Main.java:336) > at org.eclipse.core.launcher.Main.basicRun(Main.java:278) > at org.eclipse.core.launcher.Main.run(Main.java:975) > at org.eclipse.core.launcher.Main.main(Main.java:952) > at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java) > at org.apache.harmony.vm.JarRunner.main(JarRunner.java:80) > 4. testInternational > Number of completions does not match expected:<1> but was:<0> > junit.framework.AssertionFailedError: Number of completions does not match expected:<1> but was:<0> > at org.eclipse.ui.workbench.texteditor.tests.HippieCompletionTest.testInternational(HippieCompletionTest.java:357) > at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java) > at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:326) > at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:203) > at org.eclipse.test.UITestApplication$3.run(UITestApplication.java:188) > at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) > at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:121) > at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java) > at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2971) > at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1912) > at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1875) > at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:417) > at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java) > at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:96) > at org.eclipse.test.UITestApplication.runApplication(UITestApplication.java:130) > at org.eclipse.test.UITestApplication.run(UITestApplication.java:55) > at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:77) > at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:92) > at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:66) > at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:396) > at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176) > at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java) > at org.eclipse.core.launcher.Main.invokeFramework(Main.java:336) > at org.eclipse.core.launcher.Main.basicRun(Main.java:278) > at org.eclipse.core.launcher.Main.run(Main.java:975) > at org.eclipse.core.launcher.Main.main(Main.java:952) > at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java) > at org.apache.harmony.vm.JarRunner.main(JarRunner.java:80) > 5. testInternationalBackwards > junit.framework.AssertionFailedError: expected:<1> but was:<0> > at org.eclipse.ui.workbench.texteditor.tests.HippieCompletionTest.testInternationalBackwards(HippieCompletionTest.java:434) > at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java) > at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:326) > at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:203) > at org.eclipse.test.UITestApplication$3.run(UITestApplication.java:188) > at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) > at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:121) > at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java) > at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2971) > at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1912) > at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1875) > at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:417) > at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java) > at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:96) > at org.eclipse.test.UITestApplication.runApplication(UITestApplication.java:130) > at org.eclipse.test.UITestApplication.run(UITestApplication.java:55) > at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:77) > at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:92) > at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:66) > at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:396) > at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176) > at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java) > at org.eclipse.core.launcher.Main.invokeFramework(Main.java:336) > at org.eclipse.core.launcher.Main.basicRun(Main.java:278) > at org.eclipse.core.launcher.Main.run(Main.java:975) > at org.eclipse.core.launcher.Main.main(Main.java:952) > at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java) > at org.apache.harmony.vm.JarRunner.main(JarRunner.java:80) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.