Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 98799 invoked from network); 7 May 2007 11:46:43 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 7 May 2007 11:46:43 -0000 Received: (qmail 18387 invoked by uid 500); 7 May 2007 11:46:43 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 18342 invoked by uid 500); 7 May 2007 11:46:43 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 18319 invoked by uid 99); 7 May 2007 11:46:42 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 May 2007 04:46:42 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 May 2007 04:46:35 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id A2BAE714065 for ; Mon, 7 May 2007 04:46:15 -0700 (PDT) Message-ID: <12278588.1178538375663.JavaMail.jira@brutus> Date: Mon, 7 May 2007 04:46:15 -0700 (PDT) From: "Alexey Varlamov (JIRA)" To: commits@harmony.apache.org Subject: [jira] Commented: (HARMONY-2321) [classlib][launcher] Launcher fails to find properties location when bad -Djava.home is specified on the command line In-Reply-To: <12410416.1164412082028.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HARMONY-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494024 ] Alexey Varlamov commented on HARMONY-2321: ------------------------------------------ The current design supports modularity in a nice way and I don't we need to alter the main idea, but fix particular impl flaws. Most simple solution is to use more specific property name for jvm location, like "org.apache.harmony.home". More robust solution would be to introduce concept of categories of properties (user vs system) in VMI, as it is done in DRLVM impl. BTW, cmd-line syntax of RI implies such separation, too (-D vs -XX:). Then launcher should setup java.home as a system property and luni natives should use the system property value (as opposite to current user property) for bootclasspath calculation. > [classlib][launcher] Launcher fails to find properties location when bad -Djava.home is specified on the command line > --------------------------------------------------------------------------------------------------------------------- > > Key: HARMONY-2321 > URL: https://issues.apache.org/jira/browse/HARMONY-2321 > Project: Harmony > Issue Type: Bug > Components: Classlib > Environment: All > Reporter: Gregory Shimansky > > A short investigation shows that launcher parses -Djava.home passed on the command line. Later on while classlib is initialized the function readClassPathFromPropertiesFile calls properties_load with file name formed as ${java.home}/lib/boot/bootclasspath.properties. If this file is not found and properties_load, then no value is assigned to org.apache.harmony.boot.class.path. > I think this system is wrong. The launcher should not pay attention to java.home passed on the command line. The location should be found from the executable path probably. RI doesn't crash or fail its boot classes when I specify bad -Djava.home on the command line. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.