harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Fursov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-3714) [drlvm][em] Known/proven race condition markup at vm\em\src\ drlemimpl.cpp (515)
Date Tue, 22 May 2007 05:24:16 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497701
] 

Mikhail Fursov commented on HARMONY-3714:
-----------------------------------------

The patch is OK. Compilation method number is used for statistics only and can differ for
a method on the same workload from run to run because of concurrency.
Please commit.

> [drlvm][em] Known/proven race condition markup at vm\em\src\ drlemimpl.cpp (515)
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-3714
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3714
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Ilya Leviev
>         Assigned To: Alexey Varlamov
>            Priority: Minor
>         Attachments: HARMONY-3714_add_markup.patch, HARMONY-3714_add_markup_update.patch
>
>
> There are thread unsafe change of nMethodsCompiled variable that result in race condition
that occur during concurrent execution of compileMethod function.
> If it not affect correctness of execution I have marked it by special API for prevention
of further alarms on this race. 
> Write -> Write data-race -Memory write at "drlemimpl.cpp":515 conflicts with a prior
memory write at "drlemimpl.cpp":515
> Stack Traces: 
> Context
> 	Function void vm_execute_java_method_array(struct _jmethodID *,union jvalue *,union
jvalue *) "ini.cpp":51
> 	Function ExecuteMethod "em_intf.cpp":43
> 	Function void DrlEMImpl::executeMethod(struct _jmethodID *,union jvalue *,union jvalue
*) "drlemimpl.cpp":509
> 	Function void JIT_execute_method_default(void *,struct _jmethodID *,union jvalue *,union
jvalue *) "ini_ia32.cpp":199
> 	Function vm_invoke_native_array_stub "ini_ia32.cpp":76
> 	Function class VM_thread * get_thread_ptr_stub(void) "thread_manager.cpp":138
> 	Function void * compile_me(struct Method *) "compile.cpp":790
> 	Function compile_do_compilation "compile.cpp":770
> 	Function CompileMethod "em_intf.cpp":49
> 	Function enum JIT_Result DrlEMImpl::compileMethod(struct Method *) "drlemimpl.cpp":512
> 1st Access
> 	Function void JIT_execute_method_default(void *,struct _jmethodID *,union jvalue *,union
jvalue *) "ini_ia32.cpp":199
> 	Function vm_invoke_native_array_stub "ini_ia32.cpp":76
> 	Function class VM_thread * get_thread_ptr_stub(void) "thread_manager.cpp":138
> 	Function m2n_free_local_handles "m2n_ia32.cpp":268
> 	Function hythread_thin_monitor_exit "thread_native_thin_monitor.c":420
> 	Function class VM_thread * get_thread_ptr_stub(void) "thread_manager.cpp":138
> 	Function void * compile_me(struct Method *) "compile.cpp":790
> 	Function compile_do_compilation "compile.cpp":770
> 	Function CompileMethod "em_intf.cpp":49
> 	Function enum JIT_Result DrlEMImpl::compileMethod(struct Method *) "drlemimpl.cpp":515
> 2nd Access
> 	Function void vm_execute_java_method_array(struct _jmethodID *,union jvalue *,union
jvalue *) "ini.cpp":51
> 	Function ExecuteMethod "em_intf.cpp":43
> 	Function void DrlEMImpl::executeMethod(struct _jmethodID *,union jvalue *,union jvalue
*) "drlemimpl.cpp":509
> 	Function void JIT_execute_method_default(void *,struct _jmethodID *,union jvalue *,union
jvalue *) "ini_ia32.cpp":199
> 	Function vm_invoke_native_array_stub "ini_ia32.cpp":76
> 	Function class VM_thread * get_thread_ptr_stub(void) "thread_manager.cpp":138
> 	Function void * compile_me(struct Method *) "compile.cpp":790
> 	Function compile_do_compilation "compile.cpp":770
> 	Function CompileMethod "em_intf.cpp":49
> 	Function enum JIT_Result DrlEMImpl::compileMethod(struct Method *) "drlemimpl.cpp":515
> Code: drlemimpl.cpp: 515
> "0x44D0"	"512"	""	" JIT_Result DrlEMImpl::compileMethod(Method_Handle mh) {"
> ""          	"513"	""	"     //initial method compilation. Select chain to use."
> ""      	"514"	""	" "
> "0x4507"	"515"	"*"	"     nMethodsCompiled++;"
> ""      	"516"	""	"     //these vars used for logging"
> "0x4516"	"517"	""	"     const char* methodName = NULL;"
> "0x451D"	"518"	""	"     const char* className = NULL;"
> "0x4524"	"519"	""	"     const char* signature = NULL;"
> "0x452B"	"520"	""	"     size_t n = nMethodsCompiled;"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message