harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexei Zakharov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-3360) [classlib][EUT] 5 tests fail in org.eclipse.ui.workbench.texteditor.tests suit
Date Mon, 21 May 2007 20:36:16 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497573
] 

Alexei Zakharov commented on HARMONY-3360:
------------------------------------------

Hi Nellya. Thanks for the your patch and your efforts. But I think applying the patch in its
present form is not a very good idea. As far as I understand internal sets of predefined symbols
are affected by this patch. However, IMHO '!', '#' and other symbols don't look like space
characters, do they? And it seems that applying this patch results in incorrect handling of
\s class. I.e. the following test (written by me) starts to fail:

import java.util.regex.*;

public class TestSpace {
    public static void main(String argv[]) {
        String str = "!\"#%&'(),-./";
        Pattern p = Pattern.compile("\\s");
        Matcher m = p.matcher(str);
        boolean found = false;

        while (m.find()) {
            System.out.println("Matching subsequence: " + m.group());
            found = true;
        }

        System.out.println(found ? "FAIL" : "PASS");
    }

}

I've added this test to MatcherTest. Could we fix the original issue in some other way?

> [classlib][EUT] 5 tests fail in org.eclipse.ui.workbench.texteditor.tests suit
> ------------------------------------------------------------------------------
>
>                 Key: HARMONY-3360
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3360
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Aleksey Ignatenko
>         Assigned To: Alexei Zakharov
>         Attachments: H-3360-test.patch, H-3360-updated.patch, H-3360-updated.patch, H-3360.patch
>
>
> 5 tests fail in org.eclipse.ui.workbench.texteditor.tests suit of EUT.
> 1. testSearchBackwards1
> expected:<1> but was:<2> 
> junit.framework.AssertionFailedError: expected:<1> but was:<2>
> at org.eclipse.ui.workbench.texteditor.tests.HippieCompletionTest.testSearchBackwards1(HippieCompletionTest.java:140)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:326)
> at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:203)
> at org.eclipse.test.UITestApplication$3.run(UITestApplication.java:188)
> at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
> at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:121)
> at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2971)
> at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1912)
> at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1875)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:417)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java)
> at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:96)
> at org.eclipse.test.UITestApplication.runApplication(UITestApplication.java:130)
> at org.eclipse.test.UITestApplication.run(UITestApplication.java:55)
> at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:77)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:92)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:66)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:396)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> at org.eclipse.core.launcher.Main.invokeFramework(Main.java:336)
> at org.eclipse.core.launcher.Main.basicRun(Main.java:278)
> at org.eclipse.core.launcher.Main.run(Main.java:975)
> at org.eclipse.core.launcher.Main.main(Main.java:952)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> at org.apache.harmony.vm.JarRunner.main(JarRunner.java:80)
> 2. testSearchBackwards2
> expected:<8> but was:<7> 
> junit.framework.AssertionFailedError: expected:<8> but was:<7>
> at org.eclipse.ui.workbench.texteditor.tests.HippieCompletionTest.testSearchBackwards2(HippieCompletionTest.java:169)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:326)
> at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:203)
> at org.eclipse.test.UITestApplication$3.run(UITestApplication.java:188)
> at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
> at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:121)
> at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2971)
> at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1912)
> at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1875)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:417)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java)
> at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:96)
> at org.eclipse.test.UITestApplication.runApplication(UITestApplication.java:130)
> at org.eclipse.test.UITestApplication.run(UITestApplication.java:55)
> at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:77)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:92)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:66)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:396)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> at org.eclipse.core.launcher.Main.invokeFramework(Main.java:336)
> at org.eclipse.core.launcher.Main.basicRun(Main.java:278)
> at org.eclipse.core.launcher.Main.run(Main.java:975)
> at org.eclipse.core.launcher.Main.main(Main.java:952)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> at org.apache.harmony.vm.JarRunner.main(JarRunner.java:80)
> 3. testSearch
> Number of completions does not match expected:<15> but was:<9> 
> junit.framework.AssertionFailedError: Number of completions does not match expected:<15>
but was:<9>
> at org.eclipse.ui.workbench.texteditor.tests.HippieCompletionTest.testSearch(HippieCompletionTest.java:203)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:326)
> at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:203)
> at org.eclipse.test.UITestApplication$3.run(UITestApplication.java:188)
> at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
> at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:121)
> at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2971)
> at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1912)
> at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1875)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:417)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java)
> at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:96)
> at org.eclipse.test.UITestApplication.runApplication(UITestApplication.java:130)
> at org.eclipse.test.UITestApplication.run(UITestApplication.java:55)
> at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:77)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:92)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:66)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:396)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> at org.eclipse.core.launcher.Main.invokeFramework(Main.java:336)
> at org.eclipse.core.launcher.Main.basicRun(Main.java:278)
> at org.eclipse.core.launcher.Main.run(Main.java:975)
> at org.eclipse.core.launcher.Main.main(Main.java:952)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> at org.apache.harmony.vm.JarRunner.main(JarRunner.java:80)
> 4. testInternational
> Number of completions does not match expected:<1> but was:<0> 
> junit.framework.AssertionFailedError: Number of completions does not match expected:<1>
but was:<0>
> at org.eclipse.ui.workbench.texteditor.tests.HippieCompletionTest.testInternational(HippieCompletionTest.java:357)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:326)
> at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:203)
> at org.eclipse.test.UITestApplication$3.run(UITestApplication.java:188)
> at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
> at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:121)
> at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2971)
> at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1912)
> at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1875)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:417)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java)
> at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:96)
> at org.eclipse.test.UITestApplication.runApplication(UITestApplication.java:130)
> at org.eclipse.test.UITestApplication.run(UITestApplication.java:55)
> at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:77)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:92)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:66)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:396)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> at org.eclipse.core.launcher.Main.invokeFramework(Main.java:336)
> at org.eclipse.core.launcher.Main.basicRun(Main.java:278)
> at org.eclipse.core.launcher.Main.run(Main.java:975)
> at org.eclipse.core.launcher.Main.main(Main.java:952)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> at org.apache.harmony.vm.JarRunner.main(JarRunner.java:80)
> 5. testInternationalBackwards
> junit.framework.AssertionFailedError: expected:<1> but was:<0>
> at org.eclipse.ui.workbench.texteditor.tests.HippieCompletionTest.testInternationalBackwards(HippieCompletionTest.java:434)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:326)
> at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:203)
> at org.eclipse.test.UITestApplication$3.run(UITestApplication.java:188)
> at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
> at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:121)
> at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2971)
> at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1912)
> at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1875)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:417)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java)
> at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:96)
> at org.eclipse.test.UITestApplication.runApplication(UITestApplication.java:130)
> at org.eclipse.test.UITestApplication.run(UITestApplication.java:55)
> at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:77)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:92)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:66)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:396)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> at org.eclipse.core.launcher.Main.invokeFramework(Main.java:336)
> at org.eclipse.core.launcher.Main.basicRun(Main.java:278)
> at org.eclipse.core.launcher.Main.run(Main.java:975)
> at org.eclipse.core.launcher.Main.main(Main.java:952)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> at org.apache.harmony.vm.JarRunner.main(JarRunner.java:80)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message