harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexei Zakharov (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HARMONY-3015) [classlib] [security] Fixes for some minor bugs in the security module found by FindBugs
Date Wed, 23 May 2007 19:01:18 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-3015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Alexei Zakharov resolved HARMONY-3015.
--------------------------------------

    Resolution: Fixed

Hi Sian,

Sorry for the long delay, couldn't find a time to get back to this bug. I understood your
idea about Object.clone() - thanks for the explanation. The patch looks good in general. I
have just a few comments:

1) I fixed DSAPublicKeyImpl.java exactly in the same way you did for DSAPrivateKeyImpl.java

2)
AlgorithIdentifier.java
Extension.java
Extensions.java
GeneralName.java
TBSCertList.java
Was there any special reason why you defined hashcode() externally for these classes? And
why you use 37 everywhere BTW? :) Just asking.


3)
TimestampTest.java
assertEquals() and friends has the format assert(EXPECTED, ACTUAL), not vice versa. So I have
swapped the parameters.

I have committed slightly updated version of your patch at the revision 541025. Please verify
I didn't break / forget anything.

> [classlib] [security] Fixes for some minor bugs in the security module found by FindBugs
> ----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3015
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3015
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Sian January
>         Assigned To: Alexei Zakharov
>            Priority: Minor
>         Attachments: exclusionFilter.xml.patch, exclusionFilter.xml.patch2, security.patch,
security.patch2
>
>
> I am attaching a patch containing fixes for minor issues in the security module, and
also a second patch for the exclusionFilter.xml file found in standard/tools/FindBugs to exclude
false positives in the same module.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message