harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Pervov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-3874) [dlrvm] "Lazy resolution" feature implementation in Jitrino compiler
Date Wed, 16 May 2007 10:58:16 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12496252
] 

Pavel Pervov commented on HARMONY-3874:
---------------------------------------

1) class_get_cp_entry_name - this is not generic entry's name, but "CONSTANT_*ref" name;
2) _WITHRESOLVE vs. _WITH_RESOLVE;
3) Please, provide C doxygen comments, not C++ (/** <text> */ vs. /// <text>)
even on single line;
4) Please, add parameter description for "is_runtime" parameter;
5) format enum ResolveResType properly (several lines);
6) +    END_RAISE_AREA;
+
+    BEGIN_RAISE_AREA;
this is kind of excessive :)
7) In rth_initialize_class_withresolve, rth_newobj_withresolve, rth_newarray_withresolve:
should initializeClass be called after resolveClass, if exception happen?
8) In rth_newarray_withresolve: assert(!exn_raised()) after class_get_array_of_class can be
triggered if OutOfMemoryError occur, assert(res!=NULL) after vm_new_vector can be triggered
by the same condition;
8) In rth_invokespecial_addr_withresolve: initializeClass can be called in exception state;
9) Should initializeClass be called only in "raise areas"?
10) In rth_invokevirtual_addr_withresolve, rth_invokeinterface_addr_withresolve: should class
of "m" be initialized?
11) In rth_get_nonstatic_field_offset_withresolve: why assuming f->get_class()->is_initialized()?
12) In rth_checkcast_withresolve: resolveClass can fail with exception;
13) type_info_get_num_array_dimesions; missing 'n' in "dimentions";
14) Concerning "//TODO: recheck!!": class_report_failure should not be called; related code
should be corrected;
15) Optimization? In class_is_cp_entry_resolved: it might be useful to update constant pool
entry to match looked-up class.

This is for VM so far. Will look into Jitrino part later.

> [dlrvm] "Lazy resolution" feature implementation in Jitrino compiler
> --------------------------------------------------------------------
>
>                 Key: HARMONY-3874
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3874
>             Project: Harmony
>          Issue Type: New Feature
>          Components: DRLVM
>            Reporter: Mikhail Fursov
>         Attachments: lazy1.zip
>
>
> This issue contains a diff and testsuite(>100 specific tests) for Lazy resolution
feature implementation in Jitrino compiler
> This is not a final patch and is not ready to commit, I run only several specs and Eclipse
on Windows with it.
> Please review and comment.
> This patch contains Jitrino.OPT only implementation. 
> I'm going to update it and add Jitrino.JET specific implementation this week and comment
all code that marked with "TODO: comment" in the patch

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message