Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 17778 invoked from network); 20 Apr 2007 01:45:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 20 Apr 2007 01:45:40 -0000 Received: (qmail 57089 invoked by uid 500); 20 Apr 2007 01:45:43 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 57060 invoked by uid 500); 20 Apr 2007 01:45:43 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 57045 invoked by uid 99); 20 Apr 2007 01:45:43 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Apr 2007 18:45:43 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Apr 2007 18:45:36 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 2A3AE714081 for ; Thu, 19 Apr 2007 18:45:16 -0700 (PDT) Message-ID: <25068310.1177033516170.JavaMail.jira@brutus> Date: Thu, 19 Apr 2007 18:45:16 -0700 (PDT) From: "Ruth Cao (JIRA)" To: commits@harmony.apache.org Subject: [jira] Commented: (HARMONY-3702) [classlib][luni] Reader and Writer convert characters incorrectly In-Reply-To: <26141655.1176925035459.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HARMONY-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490216 ] Ruth Cao commented on HARMONY-3702: ----------------------------------- Vasily, thank you for your test file. I've looked into this bug and found it is due to the different default encoding between RI, IBMVME and DRLVM. More information can be found at HARMONY-3307: http://issues.apache.org/jira/browse/HARMONY-3307#action_12488642 Thus, IMHO, it might be a non-bug difference for Harmony and RI. How do you think? > [classlib][luni] Reader and Writer convert characters incorrectly > ----------------------------------------------------------------- > > Key: HARMONY-3702 > URL: https://issues.apache.org/jira/browse/HARMONY-3702 > Project: Harmony > Issue Type: Bug > Components: Classlib > Reporter: Vasily Zakharov > Attachments: test.dat > > > java.io.Reader converts bytes to characters differently than RI does. Also, java.io.Writer converts characters to bytes differently than RI does. > The attached test.dat file contains random test data and must be placed to the current directory. ReaderTest below reads that file with FileReader and then dumps it to standard output by converting each character to int. WriterTest reads the test.dat file with FileInputStream, converts each byte to character by casting and then dumps the resulting characters to standard output by OutputStreamWriter. > public class ReaderTest { > public static void main(String args[]) throws Exception { > char[] buffer = new char[0x100000]; > java.io.Reader reader = new java.io.FileReader("test.dat"); > int length = reader.read(buffer, 0, buffer.length); > for (int i = 0; i < length; i++) { > System.out.println((int) buffer[i]); > } > } > } > public class WriterTest { > public static void main(String args[]) throws Exception { > byte[] buffer = new byte[0x100000]; > java.io.InputStream iStream = new java.io.FileInputStream("test.dat"); > int length = iStream.read(buffer, 0, buffer.length); > char[] charBuffer = new char[length]; > for (int i = 0; i < length; i++) { > charBuffer[i] = (char) buffer[i]; > } > java.io.Writer writer = new java.io.OutputStreamWriter(System.out); > writer.write(charBuffer, 0, length); > writer.close(); > } > } > In both cases, output files on RI and on Harmony are different: > $ RI/bin/java ReaderTest > reader.ri > $ HY/bin/java ReaderTest > reader.hy > $ diff --binary -q reader.ri reader.hy > Files reader.ri and reader.hy differ > $ RI/bin/java WriterTest > writer.ri > $ HY/bin/java WriterTest > writer.hy > $ diff --binary -q writer.ri writer.hy > Files writer.ri and writer.hy differ > My investigations show that the problem is in Reader/Writer, not in InputStream/OutputStream. Also, I've tried other implementations of Reader/Writer and they share the same problem. > The problem was discovered on Windows XP/IA-32 but probably affects other platforms too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.