harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Petrenko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-3570) [classlib][awt] Png decoder does not work on Linux x86_64
Date Sun, 15 Apr 2007 07:01:15 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488922
] 

Alexey Petrenko commented on HARMONY-3570:
------------------------------------------

I got one more concern about this patch after the small investigation.

Andrey, Alexei,
you've changed the type of width and height fields from int to unsigned long (png_uint_32)
in native code. But this native fields has the direct representation in Java code: imageWidth
and imageHeight fields of org.apache.harmony.awt.gl.image.PngDecoder class. And these fields
are of type int.

Guys, are your sure that this is ok to change the type in native code and leave the type unchanged
in Java code?
I have no idea here since no evaluation for the patch has been provided.

> [classlib][awt] Png decoder does not work on Linux x86_64
> ---------------------------------------------------------
>
>                 Key: HARMONY-3570
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3570
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Andrey Pavlenko
>         Assigned To: Alexei Zakharov
>         Attachments: HARMONY-3570.patch
>
>
> The test attached to HARMONY-1954 fails on Linux x86_64 with png images.
> Test output:
> Fjava.lang.RuntimeException: Invalid image width
>         at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
>         at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
>         at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
>         at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> java.lang.RuntimeException: Invalid image width
>         at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
>         at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
>         at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
>         at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> Time: 8.183
> There was 1 failure:
> 1) png(ImageDecoderTest)junit.framework.AssertionFailedError: expected:<320> but
was:<-1>
>         at ImageDecoderTest.decodeImage(ImageDecoderTest.java:57)
>         at ImageDecoderTest.testDecodeImage(ImageDecoderTest.java:43)
>         at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message