harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Svetlana Konovalova (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HARMONY-3310) [drlvm][doc] interpreter headers should be complemented with code comments
Date Mon, 02 Apr 2007 07:32:32 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Svetlana Konovalova updated HARMONY-3310:
-----------------------------------------

    Attachment: 3_interpreter_headers.patch

Ilya,
thanks for adding file descriptions. but still we have certain issues to resolve.
would you be so kind to fix the following?

1. Add missing comments for the following:
 - [interpreter_imports.h] typedef struct ManagedObject ManagedObject
 - [interpreter_exports.h] typedef struct FrameHandle FrameHandle

2. Add missing interpreter_exports.h parameter types, for example to:
            * @param bsp - the pointer to the register
            * @param reg - the register

3. [interpreter_exports.h] 
 Ln 262 "jvmtiEnv's"  
 Need to add the type of element it is. Is it an option, a variable, or what? And we shouldn't
use plural form for a code name.

4. [interpreter_exports.h] 
Ln 326 Returns <code>TRUE</code> if interpreter table. 
It defiantly should be paraphrased. The original version does not make sense. 

5. [interpreter_ exports.h] 
The definition of the group does not include the description of what Open Interfaces include.
Do they include the interface functions defined by the OPEN design? Could we provide the link
or something? 

If you have any questions, do not hesitate to contact me any time.
Thanks in advance.

Sveta


> [drlvm][doc] interpreter headers should be complemented with code comments
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-3310
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3310
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Nadya Morozova
>         Attachments: 3_interpreter_headers.patch, 3_interpreter_headers.patch, interp_defs_comments.patch,
interpreter_exports_h_comments.patch, interpreter_h_comments.patch, interpreter_imports_h_comments.patch
>
>
> header files located in drlvm\trunk\vm\interpreter\src have very scarse comments. i suggest
that we improve those.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message