harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-3537) [drlvm]Race conditions while HWA running on interpreter
Date Mon, 02 Apr 2007 05:26:32 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-3537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485937

Alexey Varlamov commented on HARMONY-3537:

Ilya, I have a few observations on the suggested patch:
1) Please extend documentation comments in the new header file, explaining rationale and semantics
behind it. Imagine a newcomer looking at the code who is not aware of long past discussions
on dev-list - so the comment needs to be self-sufficient.
2) Declaring the markers as inline functions is too  C++ -  & ThreadChecker- oriented.
Why not use plain old macros?
3) I'd like to ask for more descriptive naming than "port_nonatomic_*". Maybe UNSAFE_REGION_START
/ UNSAFE_REGION_END ? Or smth like that.

> [drlvm]Race conditions while HWA running on interpreter
> -------------------------------------------------------
>                 Key: HARMONY-3537
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3537
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Ilya Leviev
>         Attachments: HARMONY-3537-mark_hwa_race_conditions.patch
> TC report about race conditions while HWA running on interpreter(debug mode). As it not
affect on correctness of program execution I have marked it by special API for prevention
of further alarms on this race conditions.
> The patch marks such race at TM module and at VMCORE/objects.
> Notes: 
> The patch contains 3 parts.
> 1) - Add new header file (port/include/port_nonatomic.h) which define functions that
mark start and end points of code area where thread unsafe operations are performed.
> 2) - Mark VMCORE/objects race conditions at vmcore/src/object/object_handles.cpp by defined
> 3) - Mark TM race conditions at thread/src/thread_native_thin_monitor.c by defined functions.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message