harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Pervov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-3402) [drlvm] j.l.Classloaders for active frames on stack are to be enumerated as strong references
Date Tue, 03 Apr 2007 13:55:33 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-3402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486360
] 

Pavel Pervov commented on HARMONY-3402:
---------------------------------------

1) In root_set_enum_common: there is no need to assign class loader to 'const ClassLoader*'
and then remove this cast with const_cast.
2) Generally, bootstrap class loader is never unloaded. Is it worth skipping any marking for
this loader?

> [drlvm] j.l.Classloaders for active frames on stack are to be enumerated as strong references
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3402
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3402
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Aleksey Ignatenko
>         Assigned To: Gregory Shimansky
>            Priority: Minor
>         Attachments: active_frames_complete_v2.patch, active_frames_force_strong_enum.patch
>
>
> j.l.Classloaders for active frames on stack are to be enumerated as strong references.
> The current model is:
> all j.l.Classloaders and j.l.Classes are enumerated as strong references. According to
class unloading discussion in dev list one can see that when there are some functions on stack
their j.l.Classes and thus j.l.Classloaders are to be reachable. It is true for interpreter
as there is "This" enumerated at every frame, but it is not true for JIT mode because in JIT
mode "This" is not specified to be save frame and thus not enumerated (and as a result not
reachable).
> The patch attached adds running through functions on stack and forcing j.l.Classloaders
(commented for a while) to be enumerated as strong references. The such forcing could be done
via boolean flag in class Classloader in drlvm, if some function of class loaded by j.l.Classloader
CL1 is on stack then mark it as force to strong enumeration. After that force this CL1 strong
enumeration in void ClassLoader::gc_enumerate() function. This issue does not affect class
unloading anyhow but it prevents possible serious errors if any class unloading appears at
drlvm.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message