harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Markov (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HARMONY-3703) [classlib][archive][netbeans] GZIPInputStream throws IOException when feeding from the network
Date Thu, 26 Apr 2007 12:13:15 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mikhail Markov updated HARMONY-3703:
------------------------------------

    Attachment: H-3703.patch

Here is the the patch fixing the problem.
It changes the previous weird algorithm of reading the trailer of GZip file (and sometimes
leading to negative values etc.) with the new one. The steps of getting the trailer (8 bytes)
are the following:
1) the first bytes are get from the buffer filled by InflaterInputStream.fill() method. The
number of bytes copied is max(8, len of this fill buffer,  len input buffer after decompresstion,
returned by Inflater.getRemaining() method).
2) The remaining bytes are read from the stream via readFully() method as before.

I've checked the patch on my machine and the above test passed.
Hope it'll fix all the cases described by Vasily (as i could not reproduce them on my machine).

Vasily, could you please check if this patch fix your problem, please?
Thanks!

> [classlib][archive][netbeans] GZIPInputStream throws IOException when feeding from the
network
> ----------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3703
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3703
>             Project: Harmony
>          Issue Type: Bug
>          Components: App-Oriented Bug Reports, Classlib
>            Reporter: Vasily Zakharov
>         Attachments: H-3703.patch
>
>
> When java.util.zip.GZIPInputStream is passed a stream constructed from a network URL,
it throws IOException (Crc mismatch) at end-of-stream. If the same content is fed through
local file URL, the problem doesn't occur. It looks like some end-of-stream detection problem
is in place, or a race condition.
> public class Test {
>     public static void main(String args[]) throws Exception {
>         byte[] buffer = new byte[0x100000];
>         String url =
>                 "http://www.netbeans.org/updates/55_1.20_.xml.gz";
>                 //"file:55_1.20_.xml.gz";
>         java.io.InputStream stream = new java.util.zip.GZIPInputStream(new java.net.URL(url).openStream());
>         int length = 0, num = 0;
>         while (num >= 0) {
>             length += num;
>             System.out.println(length);
>             num = stream.read(buffer, length, (buffer.length - length));
>         }
>     }
> }
> $ Ri/bin/java -Dhttp.proxyHost=$PROXY_HOST -Dhttp.proxyPort=$PROXY_PORT Test
> 0
> 777
> 3392
> ...
> 386431
> SUCCESS
> $ HY/bin/java -Dhttp.proxyHost=$PROXY_HOST -Dhttp.proxyPort=$PROXY_PORT Test
> 0
> 777
> 3392
> ...
> 386431
> Exception in thread "main" java.io.IOException: Crc mismatch
>         at java.util.zip.GZIPInputStream.read(GZIPInputStream.java:166)
>         at Test.main(Test.java:13)
> On IBM VM, this result is stable. On DRLVM, the test sometimes (rarely) passes, and sometimes
(also rarely) another exception occurs instead of IOException:
> Uncaught exception in main:
> java.lang.ArrayIndexOutOfBoundsException: bad arrayCopy
>         at java.lang.VMMemoryManager.arrayCopy(VMMemoryManager.java)
>         at java.lang.System.arraycopy(System.java:86)
>         at java.util.zip.GZIPInputStream.read(GZIPInputStream.java:161)
>         at Test.main(Test.java:13)
> If content is previously downloaded (wget http://www.netbeans.org/updates/55_1.20_.xml.gz)
and local file URL is used instead of network URL (comment line 5, uncomment line 6), output
on Harmony becomes identical to output on RI.
> This problem was discovered while trying to run NetBeans on Harmony. 
> Issue HARMONY-3702 was also filed while investigating this one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message