Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <26041840.1174036870176.JavaMail.jira@brutus>
Date: Fri, 16 Mar 2007 02:21:10 -0700 (PDT)
From: "Richard Liang (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Resolved: (HARMONY-3400) [classlib][luni] Add testcase for
 ObjectInputStream's resolveObject(Object) function
In-Reply-To: <20554498.1173945429219.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HARMONY-3400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Liang resolved HARMONY-3400.
------------------------------------

    Resolution: Fixed

Hello Sean,

The patch has been applied at revision r518898 with minor modifications, thanks a lot for this enhancement.

Best regards,
Richard

> [classlib][luni] Add testcase for ObjectInputStream's resolveObject(Object) function
> ------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3400
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3400
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: ubuntu
>            Reporter: Sean Qiu
>         Assigned To: Richard Liang
>         Attachments: Harmony-3400.diff
>
>
> Add missing test case for java.io.ObjectInputStream#resolveObject(Object)
> Exist testcase only test the subclass' resolveObject rather than testing the super one.
> --------- Add test in ObjectInputStreamTest.java---------------------
>     static class ObjectInputStreamWithResolveObject extends ObjectInputStream {
>         public ObjectInputStreamWithResolveObject(InputStream in) throws IOException {
>             super(in);
>             enableResolveObject(true);
>         }
>         
>         protected Object resolveObject(Object obj) throws IOException {
>             if(obj instanceof Integer){
>                 obj = new Integer(1000);
>             }
>             return super.resolveObject(obj);
>         }        
>     }
>     
>     /**
>      * @tests java.io.ObjectInputStream#resolveObject(Object)
>      */
>     public void test_resolveObjectLjava_lang_Object() throws Exception {
>         // Write an Integer object into memory
>         Integer original = new Integer(10);
>         ByteArrayOutputStream baos = new ByteArrayOutputStream();
>         ObjectOutputStream oos = new ObjectOutputStream(baos);
>         oos.writeObject(original);
>         oos.flush();
>         oos.close();
>         // Read the object from memory
>         byte[] bytes = baos.toByteArray();
>         ByteArrayInputStream bais = new ByteArrayInputStream(bytes);
>         ObjectInputStreamWithResolveObject ois = 
>             new ObjectInputStreamWithResolveObject(bais);
>         Integer actual = (Integer) ois.readObject();
>         ois.close();
>         // object should be resolved from 10 to 1000 
>         assertEquals(new Integer(1000), actual);
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.