Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 5909 invoked from network); 14 Mar 2007 12:41:31 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 14 Mar 2007 12:41:31 -0000 Received: (qmail 83681 invoked by uid 500); 14 Mar 2007 12:41:39 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 83663 invoked by uid 500); 14 Mar 2007 12:41:39 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 83654 invoked by uid 99); 14 Mar 2007 12:41:39 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Mar 2007 05:41:39 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Mar 2007 05:41:29 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 9EE57714072 for ; Wed, 14 Mar 2007 05:41:09 -0700 (PDT) Message-ID: <17571202.1173876069648.JavaMail.jira@brutus> Date: Wed, 14 Mar 2007 05:41:09 -0700 (PDT) From: "Nadya Morozova (JIRA)" To: commits@harmony.apache.org Subject: [jira] Commented: (HARMONY-3358) [drlvm][doc] comments for bytecodes.h In-Reply-To: <9586666.1173691389637.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HARMONY-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480747 ] Nadya Morozova commented on HARMONY-3358: ----------------------------------------- Ilia, thanks for adding comments to the file. i think the more such patches the better. i'm looking into the patch now, and would ask you to fix the following cosmetic changes: - tabs used instead of whitespace occasionallyl - extra opening < symbol at the very bottom of the file at OPCODE_BREAKPOINT = OPCODE_COUNT /**< > [drlvm][doc] comments for bytecodes.h > ------------------------------------- > > Key: HARMONY-3358 > URL: https://issues.apache.org/jira/browse/HARMONY-3358 > Project: Harmony > Issue Type: Improvement > Components: DRLVM > Reporter: Ilya Leviev > Assigned To: Nadya Morozova > Attachments: HARMONY-3358-add-comments-to-bytecodes-h.patch > > > Header file bytecodes.h located in drlvm\trunk\vm\include\open has not enough comments. I have attached the patch that improves it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.