[ https://issues.apache.org/jira/browse/HARMONY-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477375 ] 

Pavel Afremov commented on HARMONY-3257:
----------------------------------------

I I think that LIL_no_tailcall_and_shadow_for_codegen.patch (3 kb) patch contains disputable changes:
-            if (i->u.call.k!=LCK_TailCall && !c->out_sig) ERR("call not dominated by out or in2out");
+            if (
+#ifndef _WIN64
+                i->u.call.k!=LCK_TailCall &&
+#endif

Hold on to commit, please.


> [drlvm][winx64] VM's "invoke_managed_func/compile_get_compile_me_generic/m2n_gen_push_m2n" stubs are not EM64T ready.
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3257
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3257
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: Windows,EM64T
>            Reporter: Mikhail Fursov
>         Attachments: combined_changes_in_vm.patch, ini.diff, jitrino.xml, LIL_no_tailcall_and_shadow_for_codegen.patch, win64conv.diff, win_x64_helpers_1.patch
>
>
> I tried to run simple tests with HARMONY-3196 patch applied on JET and found the following problem:
> before any method is compiled VM generates and executes these stubs:
> invoke_managed_func : vm\vmcore\src\util\em64t\base\ini_em64t.cpp 
> compile_get_compile_me_generic : vm\vmcore\src\util\em64t\base\compile_em64t.cpp 
> m2n_gen_push_m2n: vm\port\src\lil\em64t\pim\m2n_em64t.cpp 
> These stubs are not WIN64 EM64T ready.
> For example the first stub uses 6 fake regs while on windows it must use only 4. On windows stack args offset must be adjusted too.
> I tried to fix the first stub but found errors in the next ones. 
> Can any VM guru who wrote Linux EM64t integration review the stubs above for WIN64 compatbility and fix them all?
> + If you have problems with jitrino.dll loading during startup try to do the following:
> 1) remove -Dvm.jitrino.cfg=release from build.bat
> 2) use my jitrino.xml (attached). This file is not indended to be included: win32 build can be broken with it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.