harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gregory Shimansky (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-3444) [drlvm][winx64] Jitrino release build produces warnings while optimizing STL.
Date Tue, 20 Mar 2007 17:00:32 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-3444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482446
] 

Gregory Shimansky commented on HARMONY-3444:
--------------------------------------------

The patch doesn't compile on Linux. In several places in jni.cpp goto cannot jump over initialization
of a new variable jtstatus.
Also the following change doesn't seem to be correct to me


-        status = jthread_attach(jni_env, java_thread, daemon);
+        IDATA jtstatus = jthread_attach(jni_env, java_thread, daemon);
         if (status != TM_ERROR_NONE) return JNI_ERR;

since in this case jtstatus should be compared with TM_ERROR_NONE, don't you think?

> [drlvm][winx64] Jitrino release build produces warnings while optimizing STL.
> -----------------------------------------------------------------------------
>
>                 Key: HARMONY-3444
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3444
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>         Environment: windows/em64t
>            Reporter: Pavel Pervov
>         Assigned To: Gregory Shimansky
>            Priority: Minor
>         Attachments: H3444.patch
>
>
> I'll attach the patch which fixes this issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message