harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-3426) [drlvm][winx64] Problem with callee save registers on Win64T
Date Tue, 20 Mar 2007 04:08:32 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482305
] 

Alexey Varlamov commented on HARMONY-3426:
------------------------------------------

Looks good except the following:

--- vm/jitrino/src/jet/compiler.cpp	(revision 519916)
+++ vm/jitrino/src/jet/compiler.cpp	(working copy)
@@ -1448,7 +1448,7 @@
-    rt_suspend_req_flag_offset = hythread_tls_get_suspend_request_offset();
+    rt_suspend_req_flag_offset = (unsigned)hythread_tls_get_suspend_request_offset();

Apparently hythread_tls_get_suspend_request_offset() should return size_t instead of UDATA,
let's fix this accordingly instead of adding casts.

> [drlvm][winx64] Problem with callee save registers on Win64T
> ------------------------------------------------------------
>
>                 Key: HARMONY-3426
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3426
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Mikhail Fursov
>         Attachments: cc.diff
>
>
> On windows64 platform RDI and RSI are callee-save registers.
> DRLVM does not treat these registers as callee-save and it can lead to a problem with
native methods calls.
> This patch fixes JIT and VM handling RSI and RDI on windows.
> Please review.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message