harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leo Li (JIRA)" <j...@apache.org>
Subject [jira] Created: (HARMONY-3373) [classlib][luni]java.io.ByteArrayOutputStream: avoid to use exception mechanism as logic in write(int)
Date Tue, 13 Mar 2007 01:49:09 GMT
[classlib][luni]java.io.ByteArrayOutputStream: avoid to use exception mechanism as logic in
write(int)
------------------------------------------------------------------------------------------------------

                 Key: HARMONY-3373
                 URL: https://issues.apache.org/jira/browse/HARMONY-3373
             Project: Harmony
          Issue Type: Improvement
          Components: Classlib
            Reporter: Leo Li


In  ByteArrayOutputStream.write(int):

     public synchronized void write(int oneByte) {
        try {
            buf[count] = (byte) oneByte;
            count++;
        } catch (IndexOutOfBoundsException e) {
            // Expand when necessary
            expand(1);
            buf[count++] = (byte) oneByte;
        } catch (NullPointerException e) {
        }
    }
 Exception mechanism is adopted as a logic to judge whether current position is out of the
boundary of the backing array. So, I recommend to use explicit condtion to judge it. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message