harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan Popov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-3319) [jdktools][jpda] JDWP unit tests fail with timeout
Date Fri, 09 Mar 2007 13:50:24 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479590

Ivan Popov commented on HARMONY-3319:

I don't think that your solution with adding special property "hy.jpda.test.forkmode" which
value is calculated depending on the value of standard property "hy.test.forkmode" according
to not trivial rules:

        <!-- run JPDA tests with forkmode=perBatch if common forkmode=once -->
        <condition property="hy.jpda.test.forkmode" value="perBatch" else="perTest">
            <equals arg1="${hy.test.forkmode}" arg2="once" />

is better than was proposed in the patch. 

You still have to divide tests into two groups, but also introduce not so evident calculation
of a special property, which one need to take into account. I think the previous suggestion
with dividing tests into two junit tasks is more clear and understandable.

> [jdktools][jpda] JDWP unit tests fail with timeout
> --------------------------------------------------
>                 Key: HARMONY-3319
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3319
>             Project: Harmony
>          Issue Type: Bug
>          Components: JDK
>         Environment: Windows/ia32, Linux/ia32, Harmony-jdk-r515478
>            Reporter: Ivan Popov
>         Assigned To: Stepan Mishura
>         Attachments: jpda_build.patch
> JDWP unit tests from JPDA component started with ant build usually fail with timeout:
> <...>   
>     [junit] TEST org.apache.harmony.jpda.tests.jdwp.ReferenceType.GetValues003Test FAILED
>     [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 9.578 sec
>     [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 9.543 sec
>     [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 9.537 sec
>     [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
>     [junit] Tests FAILED (timeout)
> <...>
> full-report:
> [junitreport] [Fatal Error] :-1:-1: Premature end of file.
> [junitreport] The file .../trunk/working_jdktools/build/test_report/TEST-org.apache.harmony.jpda.tests.jdwp.ReferenceType.InterfacesTest.xml
is not a valid XML document. It is possibly corrupted.
> The problem is in default timeout (120000 milliseconds, or 15 minutes) specified for
junit task in 'timeout" option:
>                timeout="${hy.test.timeout}"
> JUnit task reference reads for this option:
>   Cancel the individual tests if they don't finish in the given time (measured in milliseconds).
Ignored if fork is disabled.
> However, it seems that this option is applied to the whole tests set specified in <batchtest>
item.  All JDWP tests are specified in a single <batchtest> and their execution usually
exceeds 15 minutes, so junit task cancels them with timeout.
> There are several "long-running" tests, each takes about 1 minute. These tests can be
moved to a separate <batchtest> item  to satisfy the default timeout.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message