harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Ignatenko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-3411) [drlvm][classloader] dead code cleanup in classloader
Date Tue, 20 Mar 2007 03:38:32 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482301

Aleksey Ignatenko commented on HARMONY-3411:

I would really apreciate if you state all places where you see it was not cleaned completely.

I see the only one place which is class_unloading_clear_mark_bits function.
My opinion is that this function is to be reused. I intended to add the second version of
patch in H-3402 for this. The main idea of H-3402 is that classloaders for methods of active
frames are to be enumerated as strong references. If you look at patch in H-3402 there are
comments "// force cl classloader to be enumerated as strong reference" - it is the same as
cl->Mark(); functionality. So then you can see that class_unloading_clear_mark_bits fucntion
is still required to clean mark bits before enumeration(Classloader::m_markBit will state
strong enumeration for classloaders from now) and therefore left as is.

This jira and H-3402 are tied actually, and I've not  had anough time yet to synchronize them.

So if you think that the old prototype is to be cleaned completely - I understand and can
do that (not to mix different parts) and will move this functionality to H-3402. Another way
is to make dependency from H-3402 on this jira and use this functionality.

> [drlvm][classloader] dead code cleanup in classloader
> -----------------------------------------------------
>                 Key: HARMONY-3411
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3411
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Aleksey Ignatenko
>         Assigned To: Gregory Shimansky
>         Attachments: cl_unloading_cleanup_v2.patch
> Dead code cleanup in classloader.
> Classloader contains dead code of the old prototype of class unloading. It is to be removed
from drlvm.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message