harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Petrenko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2895) [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicFileChooserUI.getApproveButtonMnemonic(null) does not throw unspecified NPE
Date Fri, 02 Mar 2007 07:40:50 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477217
] 

Alexey Petrenko commented on HARMONY-2895:
------------------------------------------

I would agree with Ilya and vote for closing this issue as non-bug difference because FileChooserUI
methods does not usualy use FileChooser which is passed as method parameter. So it looks illogical
to throw an exception in few methods and do not throw in others.


> [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicFileChooserUI.getApproveButtonMnemonic(null)
does not throw unspecified NPE
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2895
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2895
>             Project: Harmony
>          Issue Type: Bug
>          Components: Non-bug differences from RI
>            Reporter: Ilya Okomin
>         Assigned To: Alexey Petrenko
>            Priority: Minor
>         Attachments: Harmony-2895-BasicFileChooserUI.patch, Harmony-2895-BasicFileChooserUITest.patch
>
>
> There is no mention of any exception in the specification. But RI throws unspecified
NPE for getApproveButtonMnemonic(null) while Harmony does not.
> Test case to reproduce, that passes on RI and fails on Harmony:
> ----------- test.java ----------------
> import javax.swing.JFileChooser;
> import javax.swing.plaf.basic.BasicFileChooserUI;
> import junit.framework.TestCase;
> import junit.textui.TestRunner;
> public class test extends TestCase {
>     public static void main(String args[]) {
>         TestRunner.run(test.class);
>     }
>     public void testRun() {
>         try {
>             BasicFileChooserUI cb = new BasicFileChooserUI(new JFileChooser());
>             cb.getApproveButtonMnemonic(null);
>             fail("NullPointerException expected");
>         } catch (NullPointerException e) {
>             // expected
>         }
>     }
> }
> ----------------------------------------
> I suppose this case can be treated as non-bug difference.
> Note: The same case with getApproveButtonToolTipText(null) and cb.getApproveButtonText((JFileChooser)
null).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message