harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-3380) [drlvm][winx64][jit] JET operates incorrectly with long values.
Date Wed, 14 Mar 2007 06:18:09 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480665
] 

Alexey Varlamov commented on HARMONY-3380:
------------------------------------------

1) Curious - why rename? 
+typedef POINTER_SIZE_SINT int_ptr;
Me personally dislikes name POINTER_SIZE_[S]INT, but it is widely adopted in DRLVM sources.

2) I suggest to use the define PI_FMT from open/types.h instead:
-                snprintf(buf, sizeof(buf), "%ld(0x%LX)", (long int)s.lval(), (long long)s.lval());
+#ifdef _WIN32
+                snprintf(buf, sizeof(buf), "%I64d(0x%I64X)", s.lval(), s.lval());
+#else
+                snprintf(buf, sizeof(buf), "%ld(0x%LX)", (long int)s.lval(), s.lval());
+#endif


> [drlvm][winx64][jit] JET operates incorrectly with long values.
> ---------------------------------------------------------------
>
>                 Key: HARMONY-3380
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3380
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: windows/em64t
>            Reporter: Pavel Rebriy
>            Priority: Critical
>         Attachments: jet.fix, jet_2.fix
>
>
> While debugging DRLVM on Windows Intel64 platform I've found that JET operates incorrectly
with long values and prevents some benchmarks to pass.
> Here is the test:
> public class Test {
>     public static void main(String[] args) {
>         long a = 0x00100000000L;
>         long b = 0x01010101010L;
>         test(a,b);
>     }
>     static void test( long a, long b ) {
>         System.out.format("a I b = %1$x%n", (a|b) );
>     }
> }
> RI prints:
> a | b = 1110101010
> Harmony (with JET):
> a | b = 10101010
> I think the cause is a problem in JET code generation on Windows Intel64.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message