Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <7787418.1171023725970.JavaMail.jira@brutus>
Date: Fri, 9 Feb 2007 04:22:05 -0800 (PST)
From: "Alexey Varlamov (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-3126) [drlvm] VMMagic: migration to new
 interfaces
In-Reply-To: <4797068.1170776285761.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HARMONY-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471676 ] 

Alexey Varlamov commented on HARMONY-3126:
------------------------------------------

Pavel, thanks for such a thorough review! 
Few observations below:
Re 3) : In method_has_annotation() I see annotations are compared by class, and this is the only correct way in general case. Therefore loading annotation classes is inavoidable, but in practice this has no overhead since only helper methods are explored.
Re 4) : ClassFileFormat dictates this, as annotations are named as descriptors and Type_Desc is just more convenient.
Re 5) : Yet better way is to compare String instances, i.e. preload magic types to Strings and compare by '==' with incoming class name.
Re 11) : With the above optimizations, no extra comparisons in VM? As for the JIT, probably no easy alternative... Maybe export VM's StringPool?

> [drlvm] VMMagic: migration to new interfaces
> --------------------------------------------
>
>                 Key: HARMONY-3126
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3126
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Mikhail Fursov
>         Assigned To: Alexey Varlamov
>         Attachments: vmmagic_1.zip, wrn.diff
>
>
> This patch contains:
> 1) all VMmagics methods updated to use annotations-like pragmas instead of obsolete exception-like
> 2) vmmagic.jar location is updated to point to the new version. Run 'build update' before building drlvm
> 3) method_has_annotation was added to VM interfaces
> 4) magic types were removed from VM/GC enumeration
> 5) some refactoting was done to simplefy EM64T port (I hope it were all VM/GC changes needed)
> 6) minor bugfixes and improvements

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.