Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <32779205.1170436325998.JavaMail.jira@brutus>
Date: Fri, 2 Feb 2007 09:12:05 -0800 (PST)
From: "Vasily Zakharov (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-2663) [classlib][swing]
 javax.swing.plaf.basic.BasicMenuUI is inconsistent with RI
In-Reply-To: <28309066.1166009784184.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HARMONY-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469804 ] 

Vasily Zakharov commented on HARMONY-2663:
------------------------------------------

Thanks Alexei, the patch is fine.

testInstallUninstallDefaults() fails on RI with or without this patch either. Enabling and verifying Swing tests is a huge issue, indeed.


> [classlib][swing] javax.swing.plaf.basic.BasicMenuUI is inconsistent with RI
> ----------------------------------------------------------------------------
>
>                 Key: HARMONY-2663
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2663
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexander Simbirtsev
>         Assigned To: Alexei Zakharov
>         Attachments: Harmony-2663-1-Test.patch, Harmony-2663-1-Test.patch, Harmony-2663-1.patch, Harmony-2663-2-Test.patch, Harmony-2663-2-Test.patch, Harmony-2663-2.patch
>
>
> 1) Harmony throws ClassCastException for getMaximumSize(new JOptionPane()) while RI throws NPE.
> 2) Harmony returns non-null value for createMenuListener() method while RI return null
> Use the following code to reproduce:
> import javax.swing.JComponent;
> import javax.swing.JMenu;
> import javax.swing.JOptionPane;
> import javax.swing.event.MenuListener;
> import javax.swing.plaf.basic.BasicMenuUI;
> import junit.framework.TestCase;
> public class Test extends TestCase {
>     public void testcase1() {                                    
>         testBasicMenuUI bm = new testBasicMenuUI();         
>         assertNull(bm.createMenuListener(new JMenu()));
>     }
>     
>     public void testcase2() {                                    
>         try {   
>            BasicMenuUI bm = new BasicMenuUI();
>            System.err.println(bm.getMaximumSize(new JOptionPane()));
>         } catch (ClassCastException e) { 
>             fail("ClassCastException thrown");
>         } catch (NullPointerException e) {
>             // expected
>         }     
>     }
> }                      
> class testBasicMenuUI extends BasicMenuUI {
>      public MenuListener createMenuListener(JComponent l)  {
>          return super.createMenuListener(l);
>      }     
> } 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.