Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <1213496.1170939066214.JavaMail.jira@brutus>
Date: Thu, 8 Feb 2007 04:51:06 -0800 (PST)
From: "Mikhail Fursov (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-3126) [drlvm] VMMagic: migration to new
 interfaces
In-Reply-To: <4797068.1170776285761.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HARMONY-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471316 ] 

Mikhail Fursov commented on HARMONY-3126:
-----------------------------------------

Alexey,
I do not agree that we need to change field_is_reference() for magic types to return false.
Reasons:
1) All magic types and methods a Java methods so any magic-incompatible JIT will compile them without any modification. In this case you will see an exception a valid message like "Not implemented"
2) We have to change a lot of places in JIT translator to add special handling for magic types in the way you proposed (when a reference is not a reference..)


> [drlvm] VMMagic: migration to new interfaces
> --------------------------------------------
>
>                 Key: HARMONY-3126
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3126
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Mikhail Fursov
>         Assigned To: Alexey Varlamov
>         Attachments: vmmagic_1.zip, wrn.diff
>
>
> This patch contains:
> 1) all VMmagics methods updated to use annotations-like pragmas instead of obsolete exception-like
> 2) vmmagic.jar location is updated to point to the new version. Run 'build update' before building drlvm
> 3) method_has_annotation was added to VM interfaces
> 4) magic types were removed from VM/GC enumeration
> 5) some refactoting was done to simplefy EM64T port (I hope it were all VM/GC changes needed)
> 6) minor bugfixes and improvements

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.