harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexei Zakharov (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HARMONY-2663) [classlib][swing] javax.swing.plaf.basic.BasicMenuUI is inconsistent with RI
Date Fri, 02 Feb 2007 14:40:06 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Alexei Zakharov resolved HARMONY-2663.
--------------------------------------

    Resolution: Fixed

New patch works good. Thanks Vasiliy. Was applied at the revision 502613. Please verify. 
BTW BasicMenuUITest.testInstallUninstallDefaults() currently fails on RI. Is it ok? Or it
is a work to do? ;)

> [classlib][swing] javax.swing.plaf.basic.BasicMenuUI is inconsistent with RI
> ----------------------------------------------------------------------------
>
>                 Key: HARMONY-2663
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2663
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexander Simbirtsev
>         Assigned To: Alexei Zakharov
>         Attachments: Harmony-2663-1-Test.patch, Harmony-2663-1-Test.patch, Harmony-2663-1.patch,
Harmony-2663-2-Test.patch, Harmony-2663-2-Test.patch, Harmony-2663-2.patch
>
>
> 1) Harmony throws ClassCastException for getMaximumSize(new JOptionPane()) while RI throws
NPE.
> 2) Harmony returns non-null value for createMenuListener() method while RI return null
> Use the following code to reproduce:
> import javax.swing.JComponent;
> import javax.swing.JMenu;
> import javax.swing.JOptionPane;
> import javax.swing.event.MenuListener;
> import javax.swing.plaf.basic.BasicMenuUI;
> import junit.framework.TestCase;
> public class Test extends TestCase {
>     public void testcase1() {                                    
>         testBasicMenuUI bm = new testBasicMenuUI();         
>         assertNull(bm.createMenuListener(new JMenu()));
>     }
>     
>     public void testcase2() {                                    
>         try {   
>            BasicMenuUI bm = new BasicMenuUI();
>            System.err.println(bm.getMaximumSize(new JOptionPane()));
>         } catch (ClassCastException e) { 
>             fail("ClassCastException thrown");
>         } catch (NullPointerException e) {
>             // expected
>         }     
>     }
> }                      
> class testBasicMenuUI extends BasicMenuUI {
>      public MenuListener createMenuListener(JComponent l)  {
>          return super.createMenuListener(l);
>      }     
> } 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message