harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey A. Ivanov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2666) [classlib][swing] javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw unspecified NPE while RI does
Date Fri, 16 Feb 2007 11:56:06 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-2666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473684
] 

Alexey A. Ivanov commented on HARMONY-2666:
-------------------------------------------

I guess the patch is not correct: Applying this patch prevents Swing applications from using
L&F decorated windows. I think this problem is much more serious than NPE-compatibility
in this case.

There should be provided another fix to this minor exception compatibility. I suggest to revert
the patch.

> [classlib][swing] javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw
unspecified NPE while RI does
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2666
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2666
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexander Simbirtsev
>         Assigned To: Mark Hindess
>            Priority: Minor
>         Attachments: Harmony-2666-BasicInternalFrameTitlePane.patch, Harmony-2666-BasicInternalFrameTitlePaneTest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony does not throw unspecified NPE for MetalInternalFrameTitlePane(null)
> while RI does.
> Use the following code to reproduce:
> import javax.swing.JInternalFrame;
> import javax.swing.plaf.basic.BasicInternalFrameTitlePane;
> import junit.framework.TestCase;
> public class Test extends TestCase {       
>     public static void main(String[] args) {                                
>         try {   
>             new BasicInternalFrameTitlePane((JInternalFrame) null);     
>         } catch (Exception e) { 
>             e.printStackTrace();
>         }                                                                       
>     }  
> }
> Inconsistency is that in Harmony's implementation of this constructor 
> installTitlePane() is not called when null parameter is passed in

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message