harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gregory Shimansky (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HARMONY-3196) [drlvm][build] enabling of drlvm build on windows/em64t
Date Tue, 20 Feb 2007 17:19:05 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Gregory Shimansky updated HARMONY-3196:

    Attachment: HARMONY-3196.patch

I've made changes to your patches. They are required because they break compilation on other
platforms. The following changes were necessary:

1. Fixed "#if defined(_EM64T_) and defined(_WIN64)" in port_atomic.c. It doesn't compile.
2. Fixed conditional declarations of port_atomic_cas* functions in port_atomic.h to be windows
specific because these declarations for Linux x86_64 are defined in another part of this file.

I also removed redundant "amd64" flags in build system. Take a look at the updated patch.
I've checked it on linux x86/x86_64 and windows x86, now it compiles and tests run ok.

I don't quite like the way you've disabled warnings on windows x86_64 specifying /W0. I know
that Microsoft has deprecated a lot of standard C API in MSVC 2005, but avoiding deprecated
warnings could be done in a different way, like this: http://www.wxwidgets.org/wiki/index.php/MSVC_.NET_Setup_Guide#MSVC_8.0_.282005.29_Deprecated_Function_Warnings
But reenabling warnings may be done later, in case not only deprecated warnings appear when
compiling VM code.

> [drlvm][build] enabling of drlvm build on windows/em64t
> -------------------------------------------------------
>                 Key: HARMONY-3196
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3196
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>         Environment: windows/em64t
>            Reporter: Ivan Zvolsky
>         Assigned To: Gregory Shimansky
>         Attachments: drlvm_build_system.patch, drlvm_cosmetic_changes.patch, drlvm_need_impl.patch,
HARMONY-3196.patch, zlib-x86_64-dll.zip
> This is a set of patches for enabling building of drlvm on windows/em64t. This issue
is linked with harmony-3188, because classlib has to be built in order to start drlvm building.
> Short descriptions of attached files:
> 1) zlib-x86_64-dll.zip - zlib library windows/em64t binaries and headers, to be placed
"as is" to some public server, and that location should be specified in win.properties file
(see drlvm_build_system.patch, line 211)
> 2) drlvm_build_system.patch - changes to the build system of drlvm
> 3) drlvm_cosmetic_changes.patch - small changes in sources to make them buildable with
msvc 2005
> 4) drlvm_need_impl.patch - changes to sources, some of which need further investigation
and fixing. I've added //TODO comment for each such issue, and also a subtask of current jira
will be created to reflect all such places.
> Some tips on running patched build:
> a) you will need msvc 2005
> b) execute like set COMPILER_CFG_SCRIPT=EM64T (so build.bat knows which environment to
> c) execute build.bat update and then build.bat

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message