harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Evgeniya Maenkova (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2584) [classlib][swing] javax.swing.plaf.basic.BasicTextUI.createKeymap() doesn't throw NPE
Date Thu, 08 Feb 2007 19:33:06 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471451
] 

Evgeniya Maenkova commented on HARMONY-2584:
--------------------------------------------

Accordingly to the class hierarchy we should look at BasicTextUI.createKeymap spec.
"The keymap has the name defined by the getKeymapName method. "
   Yeah, it has in our case.

"If the keymap is not found, then DEFAULT_KEYMAP from JTextComponent is used. ". 
   So NPE isn't looking reasonable accordingly to the docs.

I believe it makes sense to leave this as is.

> [classlib][swing] javax.swing.plaf.basic.BasicTextUI.createKeymap() doesn't throw NPE
> -------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2584
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2584
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Anton Luht
>            Priority: Minor
>
> Compatibility issue: RI throws NullPointerException for method
> javax.swing.plaf.basic.BasicTextUI.createKeymap(), but Harmony just works
> silently.
> Code to reproduce:
> import javax.swing.plaf.basic.*;
> import javax.swing.text.Keymap;
> class lBasicTextFieldUI extends BasicTextFieldUI {
>         public Keymap createKeymap() {
>                 return super.createKeymap();
>         }
> }
> public class Test {
>         public static void main(String args[]) {
>                 lBasicTextFieldUI localBasicTextFieldUI = new lBasicTextFieldUI();
>                 Keymap returnValue = localBasicTextFieldUI.createKeymap();
>                 System.out.println("returnValue = " + returnValue);
>         }
> }
> Output in RI:
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> Exception in thread "main" java.lang.NullPointerException
>         at sun.swing.DefaultLookup.get(Unknown Source)
>         at javax.swing.plaf.basic.BasicTextUI.createKeymap(Unknown Source)
>         at lBasicTextFieldUI.createKeymap(Test.java:8)
>         at Test.main(Test.java:15)
> Output in Harmony:
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundatio
> n or its licensors, as applicable.
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r485537, (Dec 11 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> returnValue = Keymap[lBasicTextFieldUI]{}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message