harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Kleymenov (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HARMONY-617) [classlib][luni] HttpURLConnection does not support persistent connections
Date Fri, 09 Feb 2007 12:07:06 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Alexander Kleymenov updated HARMONY-617:
----------------------------------------

    Attachment: test.patch

While working on testing of HTTPS with persistent connections I've found
some problems.

HttpConnectionManager.java:
    - does not allow to get connection if SecurityManager is set 
      (problem with getProperty)
    - security issue: there is no SecurityManager checkConnect 
      in getConnection methods
    - ConnectionPool.returnConnectionToPool should make sure 
      that connection was not already returned

HttpURLConnectionTest.java:
    - uses connection to internet. Tests fails if  there is no (direct) internet connection

I've supplemented HttpURLConnectionTest.java with Mock HTTP Server 
and one test case. RI works fine on this test, but Harmony fails. 
I think the problem is with returning of the used connection back to the pool.
It should be done after HttpURLConnection's input stream has reached his end.
I leave some debug output in the test, 
so it should be easy to understand its work.
Please, look at the problem revealed by new test case. Attached patch
should be applied over your patch.

Also there are several style/indentation problems, tabs using, and trailing 
spaces in the sources.

I'm proceeding with testing.

Thanks,
Alexander

> [classlib][luni] HttpURLConnection does not support persistent connections
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-617
>                 URL: https://issues.apache.org/jira/browse/HARMONY-617
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexander Kleymenov
>         Assigned To: Paulex Yang
>         Attachments: luni.patch, test.patch
>
>
> Current HttpURLConnection does not support persistent connections while RI implementation
does.
> Implementation of this mechanism will allow sufficiently increase the performance of
network applications based on HttpURLConnections. To make Harmony's implementation more attractive
for use this support SHALL be implemented.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message