harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Petrenko (JIRA)" <j...@apache.org>
Subject [jira] Reopened: (HARMONY-2606) [classlib][swing][plaf] javax.swing.plaf.basic.BasicFileChooserUI.ensureFileIsVisible(..) throws unexpected NPE
Date Fri, 02 Feb 2007 15:14:06 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Alexey Petrenko reopened HARMONY-2606:
--------------------------------------


JFileChooser instance passed as parameter should not be assigned to internal fileChooser variable.

=== cut ===
import java.io.File;
import javax.swing.JFileChooser;
import javax.swing.plaf.basic.BasicFileChooserUI;

public class Harmony2606Test {
    public static void main(String argv[]) {
        BasicFileChooserUI fc = new BasicFileChooserUI(null);  
        File file = new File("a");
        fc.ensureFileIsVisible(new JFileChooser() {
            public void ensureFileIsVisible(File f) {
                System.err.println("ensure called");
                super.ensureFileIsVisible(f);
            }
        }, file); 
    }
}
=== cut ===

This test will print "ensure called" string if ensureFileIsVisible uses JFileChooser instance
passed as parameter and will be silent otherwise.

RI output:
C:\Work\tests>:\Java\jrockit-jdk1.5.0-windows-ia32\bin\java.exe Harmony2606Test
<silent>

Harmony with your patch:
C:\Work\tests>\harmony\working_classlib\deploy\jdk\jre\bin\java.exe Harmony2606Test
ensure called

So Harmony's behavior with this patch differs from RI and brakes all the further operations
of this BasicFileChooserUI instance.

Patch should be changed.


> [classlib][swing][plaf] javax.swing.plaf.basic.BasicFileChooserUI.ensureFileIsVisible(..)
throws unexpected NPE
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2606
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2606
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Anton Luht
>         Assigned To: Mark Hindess
>            Priority: Minor
>         Attachments: Harmony-2606-BasicFileChooserUI.patch, Harmony-2606-BasicFileChooserUITest.patch
>
>
> If an instance of javax.swing.plaf.basic.BasicFileChooserUI was created using constructor
with null argument, its method ensureFileIsVisible(JFileChooser, File) throws NPE in Harmony
but doesn't throw in RI
> Code to reproduce:
> import javax.swing.*;
> import javax.swing.plaf.*;
> import javax.swing.plaf.basic.*;
> import java.io.*;
> public class Test {
>    public static void main(String[] argv) {
>      BasicFileChooserUI localBasicFileChooserUI = new BasicFileChooserUI(null);
>      localBasicFileChooserUI.ensureFileIsVisible(new JFileChooser(), new File("a"));
>    }
> }
> Output in RI:
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> <none>
> Output in Harmony:
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundatio
> n or its licensors, as applicable.
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r485537, (Dec 11 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> Uncaught exception in main:
> java.lang.NullPointerException
>         at javax.swing.plaf.basic.BasicFileChooserUI.ensureFileIsVisible(BasicFi
> leChooserUI.java)
>         at Test.main(Test.java:10)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message