harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Pervov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-3126) [drlvm] VMMagic: migration to new interfaces
Date Fri, 09 Feb 2007 12:42:06 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471680
] 

Pavel Pervov commented on HARMONY-3126:
---------------------------------------

Re 3,4: agree.
Re Re 5: yes, this will help more.
In is_magic_type_name should condition (name->len >= MAGIC_TYPE_PACKAGE) be reversed
(name->len <= MAGIC_TYPE_PACKAGE) to correctly identify names, which are not magics?
Also, length of longest of magic types can be introduced to cut out names which are longer,
than any available magic class, and thus is not magic.

Something like,

if(name->len <= MAGIC_TYPE_PACKAGE || name->len > longest_magic_name)
    return false;

Re 11: should more of VM magics support be moved to VM (Class Support probably)?

> [drlvm] VMMagic: migration to new interfaces
> --------------------------------------------
>
>                 Key: HARMONY-3126
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3126
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Mikhail Fursov
>         Assigned To: Alexey Varlamov
>         Attachments: vmmagic_1.zip, wrn.diff
>
>
> This patch contains:
> 1) all VMmagics methods updated to use annotations-like pragmas instead of obsolete exception-like
> 2) vmmagic.jar location is updated to point to the new version. Run 'build update' before
building drlvm
> 3) method_has_annotation was added to VM interfaces
> 4) magic types were removed from VM/GC enumeration
> 5) some refactoting was done to simplefy EM64T port (I hope it were all VM/GC changes
needed)
> 6) minor bugfixes and improvements

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message